Skip to content

Add streaming support for netcore and netfx#2801

Merged
apoorvdeshmukh merged 4 commits intodotnet:feat-jsonsupportfrom
apoorvdeshmukh:dev/streaming-support
Sep 3, 2024
Merged

Add streaming support for netcore and netfx#2801
apoorvdeshmukh merged 4 commits intodotnet:feat-jsonsupportfrom
apoorvdeshmukh:dev/streaming-support

Conversation

@apoorvdeshmukh
Copy link
Copy Markdown
Contributor

This PR adds support for streaming JSON datatype to and from SQL Server.

@apoorvdeshmukh apoorvdeshmukh added the Area\Json Use this for issues that are targeted for the Json feature in the driver. label Aug 21, 2024
@apoorvdeshmukh apoorvdeshmukh marked this pull request as draft August 21, 2024 14:07
Comment thread src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonStreamTest.cs Outdated
@apoorvdeshmukh apoorvdeshmukh marked this pull request as ready for review August 26, 2024 16:04
@deepaksa1
Copy link
Copy Markdown
Contributor

Does the test cases cover SqlDataReader.GetStream() ?

@apoorvdeshmukh
Copy link
Copy Markdown
Contributor Author

Does the test cases cover SqlDataReader.GetStream() ?

As per the docs GetStream() API is only supported for binary, image, varbinary and udt datatypes hence not required as part of the current testing.

Copy link
Copy Markdown
Contributor

@deepaksa1 deepaksa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apoorvdeshmukh apoorvdeshmukh merged commit b8a03e5 into dotnet:feat-jsonsupport Sep 3, 2024
deepaksa1 pushed a commit to deepaksa1/SqlClient that referenced this pull request Sep 4, 2024
This commit adds support for streaming JSON data to and from Sql Server
apoorvdeshmukh added a commit to apoorvdeshmukh/SqlClient that referenced this pull request Sep 23, 2024
This commit adds support for streaming JSON data to and from Sql Server
@apoorvdeshmukh apoorvdeshmukh deleted the dev/streaming-support branch February 19, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Json Use this for issues that are targeted for the Json feature in the driver.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants