Fix SqlDataReader.IsDBNull() for json#2830
Merged
deepaksa1 merged 3 commits intodotnet:feat-jsonsupportfrom Sep 4, 2024
Merged
Fix SqlDataReader.IsDBNull() for json#2830deepaksa1 merged 3 commits intodotnet:feat-jsonsupportfrom
deepaksa1 merged 3 commits intodotnet:feat-jsonsupportfrom
Conversation
Contributor
|
Possible to add a test? |
Contributor
apoorvdeshmukh
left a comment
apoorvdeshmukh
left a comment
There was a problem hiding this comment.
Looks good. Please add a testcase that fails without your fix.
saurabh500
approved these changes
Sep 3, 2024
roji
reviewed
Sep 3, 2024
apoorvdeshmukh
approved these changes
Sep 3, 2024
Contributor
apoorvdeshmukh
left a comment
apoorvdeshmukh
left a comment
There was a problem hiding this comment.
Suggested few minor changes.
deepaksa1
force-pushed
the
dev/jsonNullFix
branch
from
6afd501 to
3990a7e
Compare
deepaksa1
added a commit
to deepaksa1/SqlClient
that referenced
this pull request
Oct 1, 2024
* fix SqlDataReader.IsDBNull() for json * add testcase * resolve PR commits
David-Engel
added
the
Area\Json
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix
SqlDataReader.IsDBNull()API for json data type.Currently, it returns false for a null json column. Adding the case for json type returns expected output.