Enhance Test Coverage for JSON datatype support#3062
Merged
apoorvdeshmukh merged 6 commits intodotnet:mainfrom Dec 11, 2024
Merged
Enhance Test Coverage for JSON datatype support#3062apoorvdeshmukh merged 6 commits intodotnet:mainfrom
apoorvdeshmukh merged 6 commits intodotnet:mainfrom
Conversation
apoorvdeshmukh
requested review from
benrr101,
cheenamalhotra,
mdaigle,
samsharma2700 and
saurabh500
cheenamalhotra
requested changes
Dec 5, 2024
edwardneal
reviewed
Dec 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
==========================================
- Coverage 72.70% 72.66% -0.04%
==========================================
Files 283 283
Lines 58975 58975
==========================================
- Hits 42875 42856 -19
- Misses 16100 16119 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheenamalhotra
approved these changes
Dec 10, 2024
Member
|
Once approved and merged, please backport this PR to release/6.0 branch too. |
saurabh500
approved these changes
Dec 11, 2024
apoorvdeshmukh
added a commit
to apoorvdeshmukh/SqlClient
that referenced
this pull request
Dec 11, 2024
Enhanced BCP tests to transfer multiple rows Added SqlDataReader specific API tests Added scenario of read MARS involving json datatype Parameterized jsonArrayElements and rows for JsonBulkCopyTests
cheenamalhotra
pushed a commit
that referenced
this pull request
Dec 11, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced BCP testcase to transfer multiple rows of JSON file.
Added missing SqlDataReader tests.