Enable central package management in repo#3333
Conversation
|
Personally I'd recommend enabling transivite pinning too: |
paulmedynski
left a comment
There was a problem hiding this comment.
Some formatting nits.
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
benrr101
left a comment
There was a problem hiding this comment.
I guess it's not bad. It's kinda doing the same thing we were doing just with built-in support.
mdaigle
left a comment
There was a problem hiding this comment.
Looks good. Added some notes on things that changed.
...crosoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
Show resolved
Hide resolved
2ddb065
|
@cheenamalhotra Hope you don't mind I resolved your merge conflict for you - just want to get this out the door for the preview release |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3333 +/- ##
===========================================
+ Coverage 65.34% 92.58% +27.23%
===========================================
Files 300 6 -294
Lines 65603 310 -65293
===========================================
- Hits 42871 287 -42584
+ Misses 22732 23 -22709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fd41121 to
a89ee55
Compare
|
Getting there @paulmedynski , hang on! |
Onboarding to modern central package management solution. For reference: https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management#enabling-central-package-management
Also fixed #3330