Fix | Fix Async issue with Azure Attestation Service #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
karinazhou
commented
Dec 6, 2019
karinazhou
commented
- Modify SqlColumnEncryptionEnclaveProvider APIs to accept more parameters to pass some custom data on driver level.
- Get rid of the initial thread caching workaround which does not work with Async scenarios.
- Add generateCustomData flag to avoid unnecessary nonce generation.
Merge From dotnet
merge dotnet to local repo
Update from Microsoft SqlClient
Update from Microsoft
Update from dotnet/SqlClient
Merge from dotnet/SqlClient
karinazhou
requested review from
David-Engel,
JRahnama,
cheenamalhotra and
saurabh500
cheenamalhotra
added
the
Breaking Change 🔨
msrajatj
reviewed
Dec 9, 2019
doc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEnclaveProvider.xml
Outdated
Show resolved
Hide resolved
msrajatj
reviewed
Dec 9, 2019
...ient/netcore/src/Microsoft/Data/SqlClient/AzureAttestationBasedEnclaveProvider.NetCoreApp.cs
Outdated
Show resolved
Hide resolved
msrajatj
reviewed
Dec 9, 2019
...ient/netcore/src/Microsoft/Data/SqlClient/AzureAttestationBasedEnclaveProvider.NetCoreApp.cs
Outdated
Show resolved
Hide resolved
msrajatj
reviewed
Dec 9, 2019
doc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEnclaveProvider.xml
Show resolved
Hide resolved
cheenamalhotra
approved these changes
Dec 13, 2019
karinazhou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.