Fix xevent test failures, avoid orphaned sessions by paulmedynski · Pull Request #3775 · dotnet/SqlClient

paulmedynski · 2025-11-17T21:46:57Z

Description

Added max event session duration where that feature is supported.
Added test name to event session name.
Flattened using blocks to statements.
Applied single-branch config to the approver policy (an unrelated change).

Copilot

Pull Request Overview

This PR fixes XEvent test failures by preventing orphaned event sessions through two key improvements: adding automatic session expiration via MAX_DURATION on SQL Server 2017+ and incorporating test names into session names for better traceability.

Key Changes:

Added version detection to conditionally set MAX_DURATION for XEvent sessions on SQL Server 2017+
Refactored XEventScope to accept test names as session prefixes for improved identification
Introduced ServerProperty enum for type-safe server property queries

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
DataTestUtility.cs	Added CurrentTestName() helper, ServerProperty enum, refactored GetSqlServerProperty() for type safety, and enhanced XEventScope with version detection and duration support
XEventsTracingTest.cs	Converted to instance class with constructor injection to pass test name to XEventScope
DataStreamTest.cs	Converted from static to instance class with constructor injection to pass test name to XEventScope

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

.azuredevops/policies/approvercountpolicy.yml:1

[nitpick] The original comment referencing a specific Merlinbot PR (line 6 in the old version) has been replaced with a generic documentation link. While the new link is useful, removing the historical reference to the PR that suggested this configuration may reduce traceability. Consider keeping both the original PR reference and the new documentation link.

# This file configures the Approver Count Policy Validator status check.  Some

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

.azuredevops/policies/approvercountpolicy.yml

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

.azuredevops/policies/approvercountpolicy.yml

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

paulmedynski

Commentary for reviewers.

.azuredevops/policies/approvercountpolicy.yml

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

paulmedynski · 2025-11-24T15:59:21Z

Ignore the Merge Code Coverage job failure - that is being worked on in #3798.

… running.

mdaigle

One request, otherwise looks good.

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

codecov · 2025-11-29T14:31:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.82%. Comparing base (995df25) to head (2464f8b).
⚠️ Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (995df25) and HEAD (2464f8b). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (995df25) HEAD (2464f8b)

addons 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3775      +/-   ##
==========================================
- Coverage   76.61%   69.82%   -6.79%     
==========================================
  Files         274      268       -6     
  Lines       43393    66432   +23039     
==========================================
+ Hits        33247    46389   +13142     
- Misses      10146    20043    +9897

Flag	Coverage Δ
addons	`?`
netcore	`69.85% <ø> (-6.83%)`	⬇️
netfx	`69.25% <ø> (-6.94%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Added IsNotManagedInstance() for XEvents tests.

* Fix xevent test failures, avoid orphaned sessions (#3775) * Fix xevent test failures, avoid orphaned sessions (#3775) - Added IsNotManagedInstance() for XEvents tests. * Disable scanning of Actions in CodeQL workflow (#3819) * - Updated CodeQL workflow config to be specific to the release/6.1 branch.

Copilot AI review requested due to automatic review settings November 17, 2025 21:46

github-project-automation bot added this to SqlClient Board Nov 17, 2025

paulmedynski moved this to In progress in SqlClient Board Nov 17, 2025

Copilot started reviewing on behalf of paulmedynski November 17, 2025 21:47 View session

Copilot finished reviewing on behalf of paulmedynski November 17, 2025 21:48

Copilot AI reviewed Nov 17, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 18, 2025 13:07

Copilot started reviewing on behalf of paulmedynski November 18, 2025 13:07 View session

Copilot finished reviewing on behalf of paulmedynski November 18, 2025 13:11

Copilot AI reviewed Nov 18, 2025

View reviewed changes

cheenamalhotra previously approved these changes Nov 18, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 20, 2025 13:10

paulmedynski dismissed cheenamalhotra’s stale review via 0e15a79 November 20, 2025 13:10

Copilot started reviewing on behalf of paulmedynski November 20, 2025 13:11 View session

Copilot finished reviewing on behalf of paulmedynski November 20, 2025 13:12

Copilot AI reviewed Nov 20, 2025

View reviewed changes

paulmedynski marked this pull request as ready for review November 20, 2025 18:31

paulmedynski requested a review from a team as a code owner November 20, 2025 18:31

Copilot AI review requested due to automatic review settings November 20, 2025 18:31

paulmedynski changed the title ~~[DRAFT] Fix xevent test failures, avoid orphaned sessions~~ Fix xevent test failures, avoid orphaned sessions Nov 20, 2025

Copilot started reviewing on behalf of paulmedynski November 20, 2025 18:31 View session

paulmedynski moved this from In progress to In review in SqlClient Board Nov 20, 2025

Copilot finished reviewing on behalf of paulmedynski November 20, 2025 18:35

Copilot AI reviewed Nov 20, 2025

View reviewed changes

paulmedynski force-pushed the dev/paul/xevents branch from 20a788e to ec9bbd4 Compare November 20, 2025 20:36

paulmedynski commented Nov 21, 2025

View reviewed changes

.azuredevops/policies/approvercountpolicy.yml Show resolved Hide resolved

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Show resolved Hide resolved

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 21, 2025 13:33

Copilot started reviewing on behalf of paulmedynski November 21, 2025 13:33 View session

Copilot finished reviewing on behalf of paulmedynski November 21, 2025 13:37

Copilot AI reviewed Nov 21, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Outdated Show resolved Hide resolved

Copilot finished reviewing on behalf of paulmedynski November 21, 2025 16:11

Copilot AI reviewed Nov 21, 2025

View reviewed changes

- Fixed XEvent session cleanup to remove sessions even if they aren't…

b895d7f

… running.

cheenamalhotra previously approved these changes Nov 24, 2025

View reviewed changes

mdaigle requested changes Nov 24, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Show resolved Hide resolved

github-project-automation bot moved this from In review to In progress in SqlClient Board Nov 24, 2025

apoorvdeshmukh previously approved these changes Nov 25, 2025

View reviewed changes

paulmedynski moved this from In progress to In review in SqlClient Board Nov 25, 2025

- Added XML docs for XEventSession test helper.

aa5cd2d

Copilot AI review requested due to automatic review settings November 25, 2025 12:26

paulmedynski dismissed stale reviews from apoorvdeshmukh and cheenamalhotra via aa5cd2d November 25, 2025 12:26

Copilot started reviewing on behalf of paulmedynski November 25, 2025 12:27 View session

Copilot finished reviewing on behalf of paulmedynski November 25, 2025 12:29

Copilot AI reviewed Nov 25, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Show resolved Hide resolved

Merge branch 'main' into dev/paul/xevents

2464f8b

mdaigle approved these changes Dec 1, 2025

View reviewed changes

apoorvdeshmukh approved these changes Dec 1, 2025

View reviewed changes

paulmedynski merged commit 71ef781 into main Dec 1, 2025
251 checks passed

paulmedynski deleted the dev/paul/xevents branch December 1, 2025 17:51

github-project-automation bot moved this from In review to Done in SqlClient Board Dec 1, 2025

paulmedynski added a commit that referenced this pull request Dec 1, 2025

Fix xevent test failures, avoid orphaned sessions (#3775)

9c8a7dd

paulmedynski added a commit that referenced this pull request Dec 1, 2025

Fix xevent test failures, avoid orphaned sessions (#3775)

0988f1b

- Added IsNotManagedInstance() for XEvents tests.

paulmedynski mentioned this pull request Dec 1, 2025

[6.1] Fix xevent test failures, avoid orphaned sessions #3817

Merged

mdaigle pushed a commit that referenced this pull request Dec 4, 2025

Fix xevent test failures, avoid orphaned sessions (#3775)

137905c

Copilot AI mentioned this pull request Dec 4, 2025

[6.0] Fix xevent and codeql (#3775)(#3819), add global.json #3827

Merged

mdaigle added a commit that referenced this pull request Dec 9, 2025

[6.0] Fix xevent and codeql (#3775)(#3819), add global.json (#3827)

fd34d5e

Conversation

paulmedynski commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

paulmedynski commented Nov 24, 2025

Uh oh!

mdaigle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov bot commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

paulmedynski commented Nov 17, 2025 •

edited

Loading

codecov bot commented Nov 29, 2025 •

edited

Loading