Tests | Widen SqlVector test criteria, roundtrip additional values in tests#3794
Merged
apoorvdeshmukh merged 3 commits intodotnet:mainfrom Dec 23, 2025
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
These are IsDataClassificationSupported and IsVectorSupported. In the process, removed the attempted caching for IsTDS8Supported. This caching didn't work properly, and never should have - the ctor for CertificateTest changed the certificate for the SQL Server instance, so the cached data could have been out of date.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
requested changes
Nov 21, 2025
Contributor
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
Can we avoid querying the server more than once per DataTestUtility property that you have touched?
github-project-automation
Bot
moved this from In review
to In progress
in SqlClient Board
paulmedynski
previously approved these changes
Dec 5, 2025
Contributor
|
@edwardneal - Looks like some conflicts need to be resolved here. |
Contributor
Author
|
Thanks @paulmedynski, I've just merged. |
apoorvdeshmukh
approved these changes
Dec 5, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
approved these changes
Dec 8, 2025
cheenamalhotra
approved these changes
Dec 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3794 +/- ##
==========================================
- Coverage 76.68% 69.04% -7.65%
==========================================
Files 274 261 -13
Lines 43299 67696 +24397
==========================================
+ Hits 33204 46738 +13534
- Misses 10095 20958 +10863
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
added
the
Area\Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
SqlVectortests to be run against a database server which supports thevectortype (not just Azure SQL instances.)float.MinValue, a value which can't be represented cleanly as a float, and negative zero) to demonstrate that they roundtrip, as per my comments on the original PR.Issues
Fixes #3789. Builds on my comments on the original PR #3433.
Testing
SqlVectortests continue to pass against a local SQL 2025 instance and a SQL Azure instance.