Skip to content

Backport PR #4063 to release/7.0: Add missing System.Data.Common package reference #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheenamalhotra merged 3 commits into from
Mar 25, 2026
Merged

Backport PR #4063 to release/7.0: Add missing System.Data.Common package reference #4074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2829592
Backport PR #4063: Add missing System.Data.Common package reference
Copilot Mar 23, 2026
084eada
Document why System.Data.Common NuGet package is explicitly required …
Copilot Mar 23, 2026
bbe1a41
Merge remote-tracking branch 'origin/release/7.0' into copilot/backpo…
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
<PackageVersion Include="Microsoft.IdentityModel.JsonWebTokens" Version="8.16.0" />
<PackageVersion Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.16.0" />
<PackageVersion Include="System.Buffers" Version="4.6.1" />
<PackageVersion Include="System.Data.Common" Version="4.3.0" />
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="10.0.3" />
<PackageVersion Include="System.Memory" Version="4.6.3" />
<PackageVersion Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
Expand Down
7 changes: 7 additions & 0 deletions src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@
<PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" />
<PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" />
<PackageReference Include="System.Buffers" />
<!-- System.Data.Common ships as an inbox assembly on .NET Framework, but the
inbox version predates APIs such as IDbColumnSchemaGenerator. Declaring
an explicit dependency on the NuGet package (which type-forwards to the
inbox assembly when the runtime already provides a newer version) ensures
that consumers also receive the updated assembly and avoid CS0012 errors
when referencing types like IDbColumnSchemaGenerator via our public API. -->
<PackageReference Include="System.Data.Common" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" />
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" />
<PackageReference Include="System.Security.Cryptography.Pkcs" />
Expand Down
7 changes: 7 additions & 0 deletions src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@
<PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" />
<PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" />
<PackageReference Include="System.Buffers" />
<!-- System.Data.Common ships as an inbox assembly on .NET Framework, but the
inbox version predates APIs such as IDbColumnSchemaGenerator. Declaring
an explicit dependency on the NuGet package (which type-forwards to the
inbox assembly when the runtime already provides a newer version) ensures
that consumers also receive the updated assembly and avoid CS0012 errors
when referencing types like IDbColumnSchemaGenerator via our public API. -->
<PackageReference Include="System.Data.Common" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" />
<PackageReference Include="System.Memory" />
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" />
Expand Down
6 changes: 6 additions & 0 deletions tools/specs/Microsoft.Data.SqlClient.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@
<dependency id="Microsoft.IdentityModel.JsonWebTokens" version="8.16.0" />
<dependency id="Microsoft.IdentityModel.Protocols.OpenIdConnect" version="8.16.0" />
<dependency id="System.Buffers" version="4.6.1" />
<!-- System.Data.Common ships as an inbox assembly on .NET Framework, but
the inbox version predates APIs such as IDbColumnSchemaGenerator.
This explicit dependency ensures consumers receive the updated NuGet
package version and avoid CS0012 errors when using types like
IDbColumnSchemaGenerator exposed through our public API. -->
<dependency id="System.Data.Common" version="4.3.0" />
<dependency id="System.Diagnostics.DiagnosticSource" version="10.0.3" />
<dependency id="System.Memory" version="4.6.3" />
<dependency id="System.Runtime.InteropServices.RuntimeInformation" version="4.3.0" />
Expand Down
Loading