Skip to content

Test | Fix Diagnostic Tests and remove Remote Executor #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheenamalhotra merged 6 commits into from
Mar 26, 2026
Merged

Test | Fix Diagnostic Tests and remove Remote Executor #4078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
93fb94e
Fix Diagnostic Tests and Remote Executor
cheenamalhotra Mar 24, 2026
cc47b9d
Fix missing using directives in DiagnosticTest.cs (#4079)
Copilot Mar 24, 2026
188221a
Fix target
cheenamalhotra Mar 24, 2026
6839698
Minor touch-ups
cheenamalhotra Mar 24, 2026
3302ca7
Ensure diagnostics are always sent synchronously after connection att…
cheenamalhotra Mar 24, 2026
a7d283c
Remove RemoteExecutor
cheenamalhotra Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1937,8 +1937,10 @@ private Task InternalOpenAsync(SqlConnectionOverrides overrides, CancellationTok
s_diagnosticListener.IsEnabled(SqlClientConnectionOpenError.Name))
{
result.Task.ContinueWith(
continuationAction: s_openAsyncComplete,
continuationAction: static (task, state) => s_openAsyncComplete(task, state),
Comment thread
cheenamalhotra marked this conversation as resolved.
state: operationId, // connection is passed in TaskCompletionSource async state
cancellationToken: CancellationToken.None, // we want the continuation task to run even if the original operation was cancelled
continuationOptions: TaskContinuationOptions.ExecuteSynchronously,
scheduler: TaskScheduler.Default
);
}
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.Data.SqlClient/tests/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
<!-- SqlClient test dependencies. -->
<ItemGroup>
<PackageVersion Include="BenchmarkDotNet" Version="0.15.8" />
<PackageVersion Include="Microsoft.DotNet.RemoteExecutor" Version="11.0.0-beta.25476.3" />
Comment thread
cheenamalhotra marked this conversation as resolved.
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.13" />
<PackageVersion Include="Microsoft.SqlServer.SqlManagementObjects" Version="181.15.0" />
<PackageVersion Include="Microsoft.SqlServer.Types" Version="170.1000.7" />
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@
<!-- to "Package". If this is not specified, the build will revert to default behavior of -->
<!-- referencing MDS via the project. -->
<ProjectReference Include="$(RepoRoot)src\Microsoft.Data.SqlClient\src\Microsoft.Data.SqlClient.csproj"
Condition="'$(ReferenceType)' != 'Package'" />
Condition="'$(ReferenceType)' != 'Package'"
Private="true" />
<PackageReference Include="Microsoft.Data.SqlClient"
Condition="'$(ReferenceType)' == 'Package'" />

Expand All @@ -360,7 +361,6 @@
<PackageReference Include="System.ValueTuple" />
<PackageReference Include="Microsoft.Data.SqlClient.SNI"
Condition="'$(ReferenceType)' != 'Package'" />
<PackageReference Include="Microsoft.DotNet.RemoteExecutor" />
<PackageReference Include="Microsoft.DotNet.XUnitExtensions" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Microsoft.SqlServer.Types" />
Expand Down Expand Up @@ -395,7 +395,6 @@
<PackageReference Include="Microsoft.Bcl.Cryptography" />
<PackageReference Include="Microsoft.Data.SqlClient.SNI.runtime"
Condition="'$(ReferenceType)' != 'Package'" />
<PackageReference Include="Microsoft.DotNet.RemoteExecutor" />
<PackageReference Include="Microsoft.DotNet.XUnitExtensions" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Microsoft.SqlServer.Types" />
Expand All @@ -422,4 +421,5 @@
<ProjectReference Include="$(TestsPath)tools/TDS/TDS.EndPoint/TDS.EndPoint.csproj" />
<ProjectReference Include="$(TestsPath)tools/TDS/TDS.Servers/TDS.Servers.csproj" />
</ItemGroup>

</Project>
Loading
Loading