Added CI test stages for SQL Server 16 and 17.#4087
Merged
paulmedynski merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
paulmedynski
added
the
Area\Tests
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI-only integration testing against legacy SQL Server versions (2016/2017) by extending the shared CI pipeline template, while explicitly disabling those legacy runs in PR validation pipelines to keep PRs fast.
Changes:
- Introduces a
runLegacySqlTestsparameter in the core CI template and gates new legacy SQL test configurations behind it. - Adds two new Windows test configurations targeting SQL Server 2016 and 2017 images.
- Explicitly disables legacy SQL stages in both PR validation pipelines.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/sqlclient-pr-project-ref-pipeline.yml | Disables legacy SQL (2016/2017) test stages for PR runs via runLegacySqlTests: false. |
| eng/pipelines/sqlclient-pr-package-ref-pipeline.yml | Disables legacy SQL (2016/2017) test stages for PR runs via runLegacySqlTests: false. |
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Adds runLegacySqlTests parameter and introduces SQL 2016/2017 Windows test configurations when enabled. |
cheenamalhotra
approved these changes
Mar 25, 2026
mdaigle
approved these changes
Mar 25, 2026
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have been missing integration test coverage against SQL Server 16 and 17. This PR adds test stages for those versions, but only for CI runs.
Testing
Manual CI runs will confirm the stages are running correctly. They may fail though - since we're pretty sure we have some regressions (see #3714 for example).