Skip to content

Changed SBOM package version to use build number#4095

Merged
paulmedynski merged 2 commits intomainfrom
dev/paul/sbom
Mar 30, 2026
Merged

Changed SBOM package version to use build number#4095
paulmedynski merged 2 commits intomainfrom
dev/paul/sbom

Conversation

@paulmedynski
Copy link
Copy Markdown
Contributor

@paulmedynski paulmedynski commented Mar 27, 2026

Description

OneBranch doesn't provide a way to specify per-job SBOM parameters, so we can't use our actual package names and versions. Instead, we must specify a single SBOM name and version that applies to all packages the pipeline creates. The build number is unique enough for this purpose.

Testing

The normal scheduled OneBranch Non-Official runs will confirm.

… can't specify the actual per-package version numbers because OneBranch doesn't provide per-job SBOM config, so the assembly build number is unique enough to apply to all package SBOMs.
@paulmedynski paulmedynski requested a review from a team as a code owner March 27, 2026 14:02
Copilot AI review requested due to automatic review settings March 27, 2026 14:02
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OneBranch SBOM configuration to use a single shared version identifier based on assemblyBuildNumber, since OneBranch doesn’t support per-job SBOM package name/version overrides.

Changes:

  • Switch SBOM packageVersion from $(mdsPackageVersion) to $(assemblyBuildNumber) in the official OneBranch pipeline.
  • Switch SBOM packageVersion from $(mdsPackageVersion) to $(assemblyBuildNumber) in the non-official OneBranch pipeline.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/pipelines/onebranch/sqlclient-official.yml Updates SBOM packageVersion to $(assemblyBuildNumber) for official OneBranch builds.
eng/pipelines/onebranch/sqlclient-non-official.yml Updates SBOM packageVersion to $(assemblyBuildNumber) for non-official OneBranch builds.

Comment thread eng/pipelines/onebranch/sqlclient-official.yml
Comment thread eng/pipelines/onebranch/sqlclient-non-official.yml
@paulmedynski paulmedynski changed the title Changed SBOM package version to use assemblyBuildNumber Changed SBOM package version to use Build.BuildNumber Mar 27, 2026
@paulmedynski paulmedynski changed the title Changed SBOM package version to use Build.BuildNumber Changed SBOM package version to use build number Mar 27, 2026
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Mar 27, 2026
@paulmedynski paulmedynski added this to the 7.1.0-preview1 milestone Mar 27, 2026
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Mar 27, 2026
@paulmedynski paulmedynski merged commit 938d245 into main Mar 30, 2026
6 of 10 checks passed
@paulmedynski paulmedynski deleted the dev/paul/sbom branch March 30, 2026 11:12
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants