Trim docs using pwsh via dotnet tool to support cross-platform local development.#4121
Merged
cheenamalhotra merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
paulmedynski
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the XML doc “TrimDocs” build step to use a pwsh local dotnet tool (restored via dotnet tool restore) so developers on macOS/Linux don’t need to install PowerShell separately.
Changes:
- Switch TrimDocs execution to
dotnet tool run pwshand adddotnet tool restorebefore running the script. - Add a
RestoreToolstarget and wire it as a dependency for doc trimming in the consolidated ref project. - Register the
powershelldotnet tool (commandpwsh) in the repo’s tool manifest.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/targets/TrimDocsForIntelliSense.targets | Replaces OS-specific PowerShell invocations with local tool restore + dotnet tool run pwsh. |
| src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj | Adds a tool-restore target and switches trimming to use the local pwsh tool. |
| dotnet-tools.json | Adds powershell tool entry providing the pwsh command. |
cheenamalhotra
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having to install powershell is a roadblock for local development on mac and linux. We can install it via dotnet tools before performing any build actions that depend on it.