Fix milestone lookup in hotfix workflow#4148
Merged
paulmedynski merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
paulmedynski
added
the
Area\Engineering
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes milestone lookup in the hotfix cherry-pick automation so that the workflow reliably reads existing milestones (instead of risking an unintended create-call behavior) and can correctly assign the matching milestone to the backport PR.
Changes:
- Update
gh apimilestone lookup to explicitly use--method GETduring pagination/field usage. - Add Bats assertions to ensure milestone lookup uses GET.
- Bump the hotfix workflow’s checkout action to
actions/checkout@v5.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/cherry-pick-hotfix.yml |
Updates workflow checkout steps to actions/checkout@v5. |
.github/scripts/tests/cherry-pick-to-release.bats |
Adds test assertions that milestone lookup calls gh api ... --method GET. |
.github/scripts/cherry-pick-to-release.sh |
Forces milestone lookup to use GET to avoid incorrect endpoint/method behavior. |
apoorvdeshmukh
approved these changes
Apr 7, 2026
mdaigle
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the milestone lookup during the hotfix cherry-pick workflow. The correct milestone, based on the "Hotfix X.Y.Z" label, should now be assigned to the new backport PR.