[7.1.0-preview1] ESRP Sign Resources Files, too#4248
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the OneBranch build/signing job template to ensure ESRP signs satellite resource assemblies (*.resources.dll) in addition to the primary assembly, addressing official pipeline failures caused by unsigned resource DLLs.
Changes:
- Expand ESRP signing search pattern to include
**/<package>.resources.dllalongside**/<package>.dll.
mdaigle
approved these changes
Apr 29, 2026
cheenamalhotra
approved these changes
Apr 29, 2026
paulmedynski
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Official pipeline was failing due to ESRP not signing the *.resources.dll files. This updates the search pattern to include the .resources.dll files. It explicitly adds that pattern rather than Microsoft.Data.SqlClient.dll (as per 🤖 suggestion) because it captures only the dlls that we built as part of the current build job.
Worth noting, if we ever switch off package build mode for official/non-official builds, we will need to change this pattern, since the dependencies will also be unsigned.