Improved Sql bulk copy error message #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
support RowID for DataTable and DataRow[]
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
2 times, most recently
from
f0af312 to
d8253f5
Compare
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
from
d8253f5 to
d82f338
Compare
DavoudEshtehari
requested review from
David-Engel,
JRahnama,
cheenamalhotra and
karinazhou
JRahnama
reviewed
Feb 26, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
from
0a2a219 to
df2ab9f
Compare
David-Engel
reviewed
Feb 26, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpTest.cs
Outdated
Show resolved
Hide resolved
...osoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/DataConversionErrorMessageTest.cs
Outdated
Show resolved
Hide resolved
…into bulkCopyError
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
from
df2ab9f to
4d1cfbf
Compare
Member
cheenamalhotra
left a comment
cheenamalhotra
left a comment
There was a problem hiding this comment.
Overall looks good!
Would really like to see same for SqlDataReader and IDataReader if possible as they're widely used.
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/BulkCopyAEErrorMessage.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/BulkCopyAEErrorMessage.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/BulkCopyAEErrorMessage.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/BulkCopyAEErrorMessage.cs
Outdated
Show resolved
Hide resolved
...osoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/DataConversionErrorMessageTest.cs
Outdated
Show resolved
Hide resolved
…/BulkCopyAEErrorMessage.cs Co-Authored-By: Cheena Malhotra <v-chmalh@microsoft.com>
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
2 times, most recently
from
71d6900 to
f9de9e2
Compare
David-Engel
reviewed
Feb 27, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTest.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
from
f9de9e2 to
fb25527
Compare
David-Engel
reviewed
Feb 27, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTest.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
4 times, most recently
from
f04f5f0 to
fa22b29
Compare
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Add an .editorconfig file? |
Member
|
Thanks @ErikEJ |
plus support short date issue at Linux
DavoudEshtehari
force-pushed
the
bulkCopyError
branch
from
fa22b29 to
928d023
Compare
David-Engel
approved these changes
Feb 28, 2020
cheenamalhotra
approved these changes
Feb 28, 2020
Contributor
|
It is enforced for us - maybe via a StyleCop rule then? |
cheenamalhotra
pushed a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the error message for wrong data type conversion with adding more detail about the source of error in the sqlBulkCopy.
In this change, the error message of converting a string to a numerical column is handled and the complementary information about the column name and the row number of the data source is added.
We brought this additional information for DataTable and DataRow[]. For the rest of the datatype supported by SqlBulkCopy, it will add in the next improvements.