Fixed the ConnectionString's password persistence in NetCore #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If PersistSecurityInfo = false be set in a ConnectionString, we should not get the password in an open sqlConnection's ConnectionString property. |
DavoudEshtehari
force-pushed
the
persistSecurityDebug
branch
from
addce8e to
731ab70
Compare
DavoudEshtehari
requested review from
David-Engel,
JRahnama,
cheenamalhotra and
karinazhou
cheenamalhotra
approved these changes
Mar 4, 2020
David-Engel
reviewed
Mar 4, 2020
Contributor
David-Engel
left a comment
David-Engel
left a comment
There was a problem hiding this comment.
There are more instances of _hasPasswordKeyword and comparing the code from netfx, netcore, and their histories, I think we should remove _hasPasswordKeyword and replace them all with correct references to HasPasswordKeyword. HasPasswordKeyword was re-introduced from the AAD auth port from netfx to netcore and looks like it should have simply replaced _hasPasswordKeyword at that time.
With set PersitSecurityInfo = false @netcore
DavoudEshtehari
force-pushed
the
persistSecurityDebug
branch
from
731ab70 to
6d20f6a
Compare
cheenamalhotra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448