Introduce support for AAD Device Code Flow authentication #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
David-Engel,
DavoudEshtehari,
JRahnama,
johnnypham,
karinazhou and
saurabh500
karinazhou
reviewed
Jun 10, 2020
doc/snippets/Microsoft.Data.SqlClient/SqlAuthenticationMethod.xml
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Jun 10, 2020
saurabh500
reviewed
Jun 10, 2020
saurabh500
reviewed
Jun 10, 2020
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Jun 10, 2020
cheenamalhotra
force-pushed
the
DeviceCodeFlow
branch
from
01939c3 to
be825fd
Compare
David-Engel
reviewed
Jun 10, 2020
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <dengel@magnitude.com>
saurabh500
reviewed
Jun 10, 2020
JRahnama
reviewed
Jun 10, 2020
JRahnama
reviewed
Jun 10, 2020
JRahnama
reviewed
Jun 10, 2020
David-Engel
reviewed
Jun 11, 2020
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Show resolved
Hide resolved
saurabh500
reviewed
Jun 11, 2020
cheenamalhotra
force-pushed
the
DeviceCodeFlow
branch
from
a3b5ad9 to
1a99c9d
Compare
cheenamalhotra
added
the
Public API 🆕
saurabh500
approved these changes
Jun 11, 2020
Contributor
saurabh500
left a comment
saurabh500
left a comment
There was a problem hiding this comment.
LGTM from API perspective.
cheenamalhotra
force-pushed
the
DeviceCodeFlow
branch
from
5d1cb4d to
83ad4ee
Compare
David-Engel
reviewed
Jul 20, 2020
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <dengel@magnitude.com>
David-Engel
reviewed
Jul 20, 2020
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/ActiveDirectoryAuthenticationProvider.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <dengel@magnitude.com>
David-Engel
approved these changes
Jul 21, 2020
johnnypham
reviewed
Jul 22, 2020
johnnypham
reviewed
Jul 22, 2020
johnnypham
reviewed
Jul 22, 2020
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
johnnypham
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for "Device Code Flow" authentication mode with MSAL.NET.
Reference documentation: OAuth2.0 Device Authorization Grant flow
Example of Connection string:
Server=<server>.database.windows.net; Authentication=Active Directory Device Code Flow; Database=Northwind;Also enables customization of Device Code Flow callback with below API:
ActiveDirectoryAuthenticationProvider.SetDeviceCodeFlowCallback(Func<DeviceCodeResult, Task> deviceCodeFlowCallbackMethod)Edit:
Added new APIs as under to enable customizations for "Active Directory Interactive" authentication experience:
ActiveDirectoryAuthenticationProvider.SetIWin32WindowFunc(Func<IWin32Window> iWin32WindowFunc)-- Applies to .NET Framework only
ActiveDirectoryAuthenticationProvider.SetParentActivityOrWindowFunc(Func<object> parentActivityOrWindowFunc)-- Applies to .NET Standard only
ActiveDirectoryAuthenticationProvider.SetCustomWebUi(ICustomWebUi customWebUi)-- Applies to .NET Framework, .NET Core and .NET Standard