Fix | Perform Null check for SqlErrors in SqlException #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
DavoudEshtehari,
JRahnama,
johnnypham and
karinazhou
johnnypham
reviewed
Aug 19, 2020
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlException.cs
Show resolved
Hide resolved
johnnypham
approved these changes
Aug 19, 2020
karinazhou
approved these changes
Aug 19, 2020
JRahnama
approved these changes
Aug 19, 2020
DavoudEshtehari
approved these changes
Aug 20, 2020
Contributor
There was a problem hiding this comment.
Should we also update documentation for the effect of default values?
Also, in some cases like State using default value doesn't make sense since it keeps the status of something, not just a plain byte.
In my opinion, It can be a source of a conceptual bug in the future.
Member
Author
|
Regarding SqlState "default" value, I think we could address it when implementing #648 . |
TrayanZapryanov
pushed a commit
to TrayanZapryanov/SqlClient
that referenced
this pull request
Aug 31, 2020
TrayanZapryanov
added a commit
to TrayanZapryanov/SqlClient
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #677