[Release/2.0] Fix configSection collision with System.Data.SqlClient type #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
changed the title
cheenamalhotra
requested review from
David-Engel,
DavoudEshtehari,
JRahnama,
johnnypham and
karinazhou
karinazhou
approved these changes
Aug 21, 2020
DavoudEshtehari
approved these changes
Aug 21, 2020
JRahnama
approved these changes
Aug 21, 2020
David-Engel
approved these changes
Aug 21, 2020
DavoudEshtehari
approved these changes
Aug 21, 2020
...qlClient/netcore/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.NetCoreApp.cs
Outdated
Show resolved
Hide resolved
karinazhou
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues when a System.Data.SqlClient type based configuration section is present in configuration files, and driver fails to cast the section since it grabs it by name.
The changes include adding a new section name for Microsoft.Data.SqlClient while also reading old name for backwards compatibility along with type comparison for both configuration sections.
The driver will support both below Configuration Sections:
[Dev notes] Also updates Assembly Version