Add shared SqlFacetAttribute #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnypham
approved these changes
Oct 21, 2020
Member
|
Could you also add tests for code coverage, I found this PR from System.Data.SqlClient you can leverage: |
Contributor
Author
|
Fixed up and added |
David-Engel
approved these changes
Nov 2, 2020
cheenamalhotra
approved these changes
Nov 2, 2020
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #700
SqlFacetAttribute was included in the netcore ref but not the implementation. This includes it (using the original System.Data.SqlClient version as template) in both netcore and netfx builds and unconditionally exposes it in the ref assemblies.
/cc @agilenut