Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Aug 28, 2023

Context: #773

We have an artifact that specifies a dependency that we cannot automatically figure out the version to (likely due to unsupported parent POMs).

We would like to work around this by ignoring the bad dependency with excludedRuntimeDependencies, and then adding it back with extraDependencies, which will use the dependency version specified in the config file:

"groupId": "androidx.wear.protolayout",
"artifactId": "protolayout-expression",
"excludedRuntimeDependencies": "org.jetbrains.kotlin.kotlin-stdlib",
"extraDependencies": "org.jetbrains.kotlin.kotlin-stdlib",

However, the way we currently process this, the dependency gets excluded because the "excludes" are processed after the "extras".

Rework the logic so we run the "excludes" first and then add in the "extras".

@jpobst jpobst marked this pull request as ready for review August 28, 2023 20:48
@jpobst jpobst requested a review from moljac August 28, 2023 20:48
Copy link
Contributor

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpobst jpobst merged commit 60a2fc7 into main Aug 29, 2023
@jpobst jpobst deleted the extra-deps-fix branch August 29, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants