Made KnownVersions public #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnownVersions should be the only place we modify when new versions are published. AndroidVersions right now provides information on what's installed and what's supported, but not what exists. For Android Manifest we also need to know what exists because Minimum Android Version and Target may be anything (regardless of what the compile version is). This is related to: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/777180
dellis1972
approved these changes
Jan 25, 2019
Contributor
Member
Author
|
@monojenkins backport to d16-0 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KnownVersions should be the only place we modify when new versions are
published. AndroidVersions right now provides information on what's
installed and what's supported, but not what exists. For Android
Manifest we also need to know what exists because Minimum Android
Version and Target may be anything (regardless of what the compile
version is). This is related to:
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/777180