Skip to content

Remove MakeBundleNativeCodeExternal task and mkbundle functionality #10208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 6 commits into from
Jun 16, 2025
Merged

Remove MakeBundleNativeCodeExternal task and mkbundle functionality #10208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84f538e
Initial plan for issue
Copilot Jun 16, 2025
642fc9b
Remove MakeBundleNativeCodeExternal task and related components
Copilot Jun 16, 2025
17dc265
Merge branch 'main' into copilot/fix-10207
jonathanpeppers Jun 16, 2025
61be1e7
[Build.Tasks] Remove blank lines from resource files
Copilot Jun 16, 2025
5bc0c10
Update src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
jonathanpeppers Jun 16, 2025
bf6708c
Update copilot-instructions.md
jonathanpeppers Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ C# code uses tabs (not spaces) and the Mono code-formatting style defined in `.e

* Use `[]` for empty arrays and *not* `Array.Empty<T>()`

* Do *NOT* leave random empty lines when removing code.

Examples of properly formatted code:

```csharp
Expand Down
1 change: 0 additions & 1 deletion Documentation/docs-mobile/messages/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ and `NNN` is a 3 digit number indicating the type of the unhandled `Exception`.
* `LNS` - `LinkAssembliesNoShrink`
* `LNT` - `Lint`
* `LWF` - `LogWarningsForFiles`
* `MBN` - `MakeBundleNativeCodeExternal`
* `MDC` - `MDoc`
* `PAI` - `PrepareAbiItems`
* `PAW` - `ParseAndroidWearProjectAndManifest`
Expand Down
27 changes: 0 additions & 27 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.cs.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@ Odeberte z projektu odkaz na {0} a místo toho přidejte balíček NuGet{1}.
<value>Adresář sady nástrojů pro cíl {0} se nenašel.</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>Převod ze sestavení na nativní kód se nezdařil. Ukončovací kód {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>Kompilátor NDK C byl ukončen s chybou. Ukončovací kód {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>Nepovedlo se najít sadu Android NDK. Ujistěte se prosím, že v Android SDK Manageru je nainstalovaná sada Android NDK, nebo pokud používáte vlastní cestu k sadě NDK, ujistěte se prosím, že vlastnost MSBuildu $(AndroidNdkDirectory) je nastavená na danou vlastní cestu.</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -861,11 +851,6 @@ Odeberte z projektu odkaz na {0} a místo toho přidejte balíček NuGet{1}.
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>Linker NDK byl ukončen s chybou. Ukončovací kód {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>Nepovedlo se najít {0}. Nainstalujte prosím balíček Android SDK Build-Tools pomocí programu {1}{2}tools{2}{3}.</value>
Expand Down
15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.de.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@ Entfernen Sie den '{0}' Verweis aus Ihrem Projekt, und fügen Sie stattdessen da
<value>Das Toolkettenverzeichnis für das Ziel "{0}" wurde nicht gefunden.</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>Fehler beim Konvertieren der Assembly in nativen Code. Exitcode: {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>Der NDK C-Compiler wurde mit einem Fehler beendet. Exitcode: {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>Das Android NDK wurde nicht gefunden. Stellen Sie sicher, dass das Android NDK im Android SDK Manager installiert ist, oder stellen Sie bei Verwendung eines benutzerdefinierten NDK-Pfads sicher, dass die MSBuild-Eigenschaft "$(AndroidNdkDirectory)" auf den benutzerdefinierten Pfad festgelegt ist.</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -861,11 +851,6 @@ Entfernen Sie den '{0}' Verweis aus Ihrem Projekt, und fügen Sie stattdessen da
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>Der NDK-Linker wurde mit einem Fehler beendet. Exitcode: {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>"{0}" wurde nicht gefunden. Installieren Sie das Paket mit den Android SDK-Buildtools mit dem Programm "{1}{2}tools{2}{3}".</value>
Expand Down
15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.es.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@ Quite la referencia de "{0}" del proyecto y agregue el paquete NuGet "{1}".
<value>No se encontró el directorio de cadena de herramientas para el destino {0}.</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>No se pudo realizar la conversión de ensamblado a código nativo. Código de salida {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>El compilador de C del NDK se cerró con un error. Código de salida {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>No se pudo encontrar Android NDK. Asegúrese de que está instalado en el Administrador de Android SDK o, si usa una ruta de acceso de NDK personalizada, asegúrese de que la propiedad $(AndroidNdkDirectory) de MSBuild está establecida en la ruta de acceso personalizada.</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -861,11 +851,6 @@ Quite la referencia de "{0}" del proyecto y agregue el paquete NuGet "{1}".
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>El enlazador de NDK se cerró con un error. Código de salida {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>No se puede encontrar "{0}". Instale el paquete Build-Tools de Android SDK con el programa "{1}{2}tools{2}{3}".</value>
Expand Down
15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.fr.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@ Supprimez la référence de '{0}' de votre projet et ajoutez plutôt le '{1}'.pa
<value>Le répertoire de chaîne d'outils pour la cible {0} est introuvable.</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>Échec de la conversion de l'assembly en code natif. Code de sortie : {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>Arrêt du compilateur NDK C à la suite d'une erreur. Code de sortie : {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>Impossible de localiser le kit Android NDK. Vérifiez que le kit Android NDK est installé dans le Gestionnaire SDK Android, ou si vous utilisez un chemin de kit NDK personnalisé, vérifiez que la propriété MSBuild $(AndroidNdkDirectory) a la valeur du chemin personnalisé.</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -861,11 +851,6 @@ Supprimez la référence de '{0}' de votre projet et ajoutez plutôt le '{1}'.pa
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>Arrêt de l'éditeur de liens NDK C à la suite d'une erreur. Code de sortie : {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>'{0}' est introuvable. Installez le package Android SDK Build-Tools avec le programme '{1}{2}Tools{2}{3}'.</value>
Expand Down
15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.it.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@ Rimuovere il riferimento '{0}' dal progetto e aggiungere invece il pacchetto NuG
<value>La directory della toolchain per la destinazione {0} non è stata trovata.</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>La conversione da assembly a codice nativo non è riuscita. Codice di uscita: {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>Il compilatore C di NDK è stato terminato con un errore. Codice di uscita: {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>Non è stato possibile trovare Android NDK. Assicurarsi che Android NDK sia installato in Gestione Android SDK, oppure se si usa un percorso NDK personalizzato, assicurarsi che la proprietà $(AndroidNdkDirectory) di MSBuild sia impostata sul percorso personalizzato.</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -861,11 +851,6 @@ Rimuovere il riferimento '{0}' dal progetto e aggiungere invece il pacchetto NuG
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>Il linker di NDK è stato terminato con un errore. Codice di uscita: {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>Non è possibile trovare `{0}`. Installare il pacchetto Android SDK Build-Tools con il programma `{1}{2}tools{2}{3}`.</value>
Expand Down
15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.ja.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,16 +843,6 @@ The following are literal names and should not be translated: ABI, 'libs/armeabi
<value>ターゲット {0} のためのツールチェーン ディレクトリが見つかりませんでした。</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>アセンブリからネイティブ コードへの変換に失敗しました。終了コード {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>NDK C コンパイラがエラーで終了しました。終了コード {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>Android NDK が見つかりませんでした。Android NDK が Android SDK マネージャーにインストールされていることを確認するか、カスタムの NDK パスを使用している場合は、$(AndroidNdkDirectory) MSBuild プロパティがカスタム パスに設定されていることを確認してください。</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -862,11 +852,6 @@ The following are literal names and should not be translated: ABI, 'libs/armeabi
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>NDK リンカーがエラーで終了しました。終了コード {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>`{0}` が見つかりません。`{1}{2}tools{2}{3}` プログラムを使用して Android SDK Build-Tools パッケージをインストールしてください。</value>
Expand Down
15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.ko.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@ The following are literal names and should not be translated: ABI, 'libs/armeabi
<value>대상 {0}용 도구 체인 디렉터리를 찾을 수 없습니다.</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>어셈블리에서 네이티브 코드로 변환하지 못했습니다. 종료 코드 {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>NDK C 컴파일러가 오류로 인해 종료되었습니다. 종료 코드 {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>Android NDK를 찾을 수 없습니다. Android SDK 관리자에 Android NDK가 설치되어 있는지 확인하거나, 사용자 지정 NDK 경로를 사용하는 경우 $(AndroidNdkDirectory) MSBuild 속성이 사용자 지정 경로로 설정되어 있는지 확인하세요.</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -861,11 +851,6 @@ The following are literal names and should not be translated: ABI, 'libs/armeabi
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>NDK 링커가 오류로 인해 종료되었습니다. 종료 코드 {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>'{0}'을(를) 찾을 수 없습니다. '{1}{2}tools{2}{3}' 프로그램을 사용하여 Android SDK Build-Tools 패키지를 설치하세요.</value>
Expand Down
15 changes: 0 additions & 15 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.pl.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@ Usuń odwołanie „{0}” z projektu i zamiast niego dodaj pakiet NuGet „{1}
<value>Nie znaleziono katalogu łańcucha narzędzi dla docelowej architektury {0}.</value>
<comment>{0} - The target architecture, such as Arm, Arm64, or X86_64</comment>
</data>
<data name="XA5102" xml:space="preserve">
<value>Konwersja z zestawu do kodu natywnego nie powiodła się. Kod zakończenia {0}</value>
<comment>In this message, the term "assembly" means the low-level language that an assembler like `as` takes as input. (This is different from most of the other messages, where the term "assembly" means the file type that the C# compiler produces.)
{0} - The exit code number</comment>
</data>
<data name="XA5103" xml:space="preserve">
<value>Kompilator języka C zestawu NDK zakończył pracę z błędem. Kod zakończenia {0}</value>
<comment>The following are literal names and should not be translated: NDK, C
{0} - The exit code number</comment>
</data>
<data name="XA5104" xml:space="preserve">
<value>Nie można było zlokalizować zestawu Android NDK. Upewnij się, że zestaw Android NDK jest zainstalowany w Menedżerze zestawów Android SDK, a jeśli używana jest niestandardowa ścieżka zestawu NDK, upewnij się, że właściwość $(AndroidNdkDirectory) narzędzia MSBuild jest ustawiona na ścieżkę niestandardową.</value>
<comment>The following are literal names and should not be translated: $(AndroidNdkDirectory)</comment>
Expand All @@ -861,11 +851,6 @@ Usuń odwołanie „{0}” z projektu i zamiast niego dodaj pakiet NuGet „{1}
<comment>{0} - The missing utility name, such as gcc or clang
{1} - The target architecture, such as Arm, Arm64, or X86_64
{2} - The path of the directory that was searched</comment>
</data>
<data name="XA5201" xml:space="preserve">
<value>Konsolidator zestawu NDK zakończył pracę z błędem. Kod zakończenia {0}</value>
<comment>The following are literal names and should not be translated: NDK
{0} - The exit code number</comment>
</data>
<data name="XA5205" xml:space="preserve">
<value>Nie można znaleźć narzędzia „{0}”. Zainstaluj pakiet Android SDK Build-Tools za pomocą programu „{1}{2}tools{2}{3}”.</value>
Expand Down
Loading
Loading