Skip to content

Remove unused MSBuild .targets files #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 3 commits into from
Jun 27, 2025
Merged

Remove unused MSBuild .targets files #10254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c0af72
Initial plan
Copilot Jun 27, 2025
cca5378
Add development guidelines to copilot instructions
Copilot Jun 27, 2025
cf2bca4
Remove unused MSBuild .targets files with no <Import> references
Copilot Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ Common build commands:
- `./dotnet-local.sh` or `dotnet-local.cmd` - Use locally built .NET tools
- `make` - Various make targets for specific components

## Development Guidelines

**Always search Microsoft documentation (MS Learn) when working with .NET, Windows, or Microsoft features, APIs, or integrations.** Use the `microsoft_docs_search` tool to find the most current and authoritative information about capabilities, best practices, and implementation patterns before making changes.

## Android Development Patterns

### API Bindings
Expand Down
5 changes: 0 additions & 5 deletions build-tools/installers/create-installers.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,6 @@
</ItemGroup>
<ItemGroup>
<_MSBuildTargetsSrcFiles Include="$(MSBuildTargetsSrcDir)\Xamarin.Android.AvailableItems.targets" />
<_MSBuildTargetsSrcFiles Include="$(MSBuildTargetsSrcDir)\Xamarin.Android.Common\ImportAfter\Microsoft.Cpp.Android.targets" />
<_MSBuildTargetsSrcFiles Include="$(MSBuildTargetsSrcDir)\Xamarin.Android.DefaultOutputPaths.targets" />
</ItemGroup>
<ItemGroup>
<_MSBuildFilesWin Include="$(MicrosoftAndroidSdkOutDir)x86\libZipSharpNative-*.dll" />
Expand Down Expand Up @@ -236,9 +234,6 @@
<_MSBuildFilesUnixSign Include="$(MicrosoftAndroidSdkOutDir)libMono.Unix.$(LibExtension)" />
</ItemGroup>
<ItemGroup>
<LegacyTargetsFiles Include="$(XamarinAndroidSourcePath)src\Xamarin.Android.Build.Tasks\MSBuild\Novell\MonoDroid.FSharp.targets" />
<LegacyTargetsFiles Include="$(XamarinAndroidSourcePath)src\Xamarin.Android.Build.Tasks\MSBuild\Novell\Novell.MonoDroid.Common.targets" />
<LegacyTargetsFiles Include="$(XamarinAndroidSourcePath)src\Xamarin.Android.Build.Tasks\MSBuild\Novell\Novell.MonoDroid.CSharp.targets" />
</ItemGroup>
<ItemGroup>
<MonoDocFiles Include="$(_MonoDocOutputPath)MonoAndroid-docs.source" />
Expand Down
4 changes: 0 additions & 4 deletions src/Xamarin.Android.Build.Tasks/MSBuild/Novell/MonoDroid.FSharp.targets
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/Xamarin.Android.Build.Tasks/MSBuild/Novell/Novell.MonoDroid.CSharp.targets
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/Xamarin.Android.Build.Tasks/MSBuild/Novell/Novell.MonoDroid.Common.targets
View file
Open in desktop

This file was deleted.

84 changes: 0 additions & 84 deletions .../MSBuild/Xamarin/Android/Xamarin.Android.Common/ImportAfter/Microsoft.Cpp.Android.targets
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions ...in.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.DefaultOutputPaths.targets
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,11 @@
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>Microsoft.Android.Sdk.Bindings.Gradle.targets</Link>
</None>
<None
Include="MSBuild\Xamarin\Android\Xamarin.Android.Common\ImportAfter\Microsoft.Cpp.Android.targets">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>Xamarin.Android.Common\ImportAfter\Microsoft.Cpp.Android.targets</Link>
</None>
<None
Include="MSBuild\Xamarin\Android\Xamarin.Android.AvailableItems.targets">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>Xamarin.Android.AvailableItems.targets</Link>
</None>
<None
Include="MSBuild\Xamarin\Android\Xamarin.Android.DefaultOutputPaths.targets">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>Xamarin.Android.DefaultOutputPaths.targets</Link>
</None>
<None Include="MSBuild\Xamarin\Android\Xamarin.Android.Designer.targets">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>Xamarin.Android.Designer.targets</Link>
Expand Down