Migrate WarnOnPreserveAttribute from ILLink step to MSBuild task#10675
Migrate WarnOnPreserveAttribute from ILLink step to MSBuild task#10675sbomer wants to merge 2 commits intodotnet:mainfrom
Conversation
Replace the ILLink custom step with an MSBuild task that runs before _RunILLink. This simplifies the build pipeline by removing a dependency on the ILLink step infrastructure while maintaining the same behavior. The new CheckForObsoletePreserveAttribute task uses System.Reflection.Metadata for fast metadata scanning instead of Mono.Cecil.
| <Target Name="_CheckForObsoletePreserveAttribute" BeforeTargets="_RunILLink"> | ||
| <CheckForObsoletePreserveAttribute Assemblies="@(ManagedAssemblyToLink)" /> | ||
| </Target> |
There was a problem hiding this comment.
This was probably the way it was before...
But should this warn on all builds, or just Release builds? As-is, you'd only see it in Release.
There was a problem hiding this comment.
Yeah, maybe. I was aiming for parity with current behavior. I made a change that should run this one for all builds.
Just a heads up that I'm planning to migrate more steps - I'll probabliy default to running them only where ILLink runs to avoid impacting Release builds, but happy to take feedback.
Address PR feedback: move _CheckForObsoletePreserveAttribute target from ILLink.targets to AssemblyResolution.targets so it runs on all builds, not just Release/trimmed builds. This gives developers earlier feedback about using the obsolete attribute.
|
I don't know why dnceng status checks are not appearing, but the run is: There is one test: 
I think we can probably just ignore the test on NativeAOT for now. |
|
Ok, I guess it was working in NativeAOT before, because we run ILLink -> Ilc like iOS does. And the warning appeared in ILLink. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 10675 in repo dotnet/android |
|
Moved to #10693 |
3 participants
Replace the ILLink custom step with an MSBuild task that runs before _RunILLink. This simplifies the build pipeline by removing a dependency on the ILLink step infrastructure while maintaining the same behavior.
The new CheckForObsoletePreserveAttribute task uses System.Reflection.Metadata for fast metadata scanning instead of Mono.Cecil.