[Mono.Android] Throw NotSupportedException for open generic type activation#11093
Closed
simonrozsival wants to merge 1 commit intomainfrom
Closed
[Mono.Android] Throw NotSupportedException for open generic type activation#11093simonrozsival wants to merge 1 commit intomainfrom
simonrozsival wants to merge 1 commit intomainfrom
Conversation
…vation JNIEnv.StartCreateInstance(Type, ...) now checks type.IsGenericTypeDefinition and throws NotSupportedException before attempting to allocate the Java object. In the legacy path, this check was performed later by ManagedPeer.Construct during FinishCreateInstance. Moving it earlier ensures both the legacy and trimmable typemap paths fail consistently for open generic types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
simonrozsival
added
trimmable-type-map
copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
IsGenericTypeDefinitionguard toJNIEnv.StartCreateInstance(Type, ...)that throwsNotSupportedExceptionbefore attempting to allocate a Java object for an open generic type (e.g.,GenericHolder<>).Background
In the legacy typemap path, open generic types are rejected by
ManagedPeer.ConstructduringFinishCreateInstance:In the trimmable typemap path,
ManagedPeer.Constructis not used — the UCO constructor handles activation. The UCO for open generic types is a no-op (ret), so the activation silently succeeds, which violates the expected behavior.Fix
Move the check earlier to
StartCreateInstance(Type, ...), beforeAllocObjectis called. This ensures consistent behavior regardless of which typemap path is active.