Skip to content

Remove unused HashSet allocations in HashJavaNames #11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Apr 16, 2026
+0 −7
Merged

Remove unused HashSet allocations in HashJavaNames #11124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/Xamarin.Android.Build.Tasks/Utilities/TypeMappingReleaseNativeAssemblyGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,19 +409,12 @@ void HashJavaNames (ConstructionState cs)
{
// We generate both 32-bit and 64-bit hashes at the construction time. Which set will be used depends on the target.
// Java map list will also be sorted when the target is known
Comment thread
jonathanpeppers marked this conversation as resolved.
var hashes32 = new HashSet<uint> ();
var hashes64 = new HashSet<ulong> ();

// Generate Java type name hashes...
for (int i = 0; i < cs.JavaMap.Count; i++) {
TypeMapJava entry = cs.JavaMap[i].Instance;

// The cast is safe, xxHash will return a 32-bit value which (for convenience) was upcast to 64-bit
entry.JavaNameHash32 = (uint)TypeMapHelper.HashJavaName (entry.JavaName, is64Bit: false);
hashes32.Add (entry.JavaNameHash32);

entry.JavaNameHash64 = TypeMapHelper.HashJavaName (entry.JavaName, is64Bit: true);
hashes64.Add (entry.JavaNameHash64);
}
}
}
Expand Down