Skip to content

preserve Link action for assemblies #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 1 commit into from
Jul 27, 2016
Merged

preserve Link action for assemblies #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/Xamarin.Android.Build.Tasks/Linker/MonoDroid.Tuner/PreserveDynamicTypes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,28 @@ public override SubStepTargets Targets {
bool preserve_dynamic;
List<AssemblyDefinition> saved = new List<AssemblyDefinition> ();

void PreserveLibrary (AssemblyDefinition assembly)
{
var action = Annotations.GetAction (assembly);
ResolveFromAssemblyStep.ProcessLibrary (context, assembly);
if (action == AssemblyAction.Link)
Annotations.SetAction (assembly, action);
}

public override void ProcessAssembly (AssemblyDefinition assembly)
{
// Preserve dynamic dependencies only when Microsoft.CSharp is referenced.
switch (assembly.Name.Name) {
case "Microsoft.CSharp":
preserve_dynamic = true;
foreach (var savedAssembly in saved)
ResolveFromAssemblyStep.ProcessLibrary (context, savedAssembly);
ResolveFromAssemblyStep.ProcessLibrary (context, assembly);
PreserveLibrary (savedAssembly);
PreserveLibrary (assembly);
break;
case "Mono.CSharp":
case "System.Core":
if (preserve_dynamic)
ResolveFromAssemblyStep.ProcessLibrary (context, assembly);
PreserveLibrary (assembly);
else
saved.Add (assembly);
break;
Expand Down