Skip to content

[Xamarin.Android.Build.Tasks] Add Properties for the Debug Key #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 4 commits into from
Mar 7, 2018
Merged

[Xamarin.Android.Build.Tasks] Add Properties for the Debug Key #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fcfba3
[Xamarin.Android.Build.Tasks] Add Properties for the Debug Key
dellis1972 Mar 6, 2018
98dea19
Added Docs
dellis1972 Mar 6, 2018
81c214a
Added Conditionals so users can override defaults
dellis1972 Mar 7, 2018
3b6553f
Fix typo
dellis1972 Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Documentation/guides/BuildProcess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,13 @@ To use the keystore generated above, use the property group:
<AndroidSigningKeyPass>keystore.alias password</AndroidSigningKeyPass>
</PropertyGroup>

- **AndroidDebugKeyAlgorithm** &ndash; Specifies the default
algorithm to use for the `debug.keystore`. It defaults to
`RSA`.

- **AndroidDebugKeyValidity** &ndash; Specifies the default
validity to use for the `debug.keystore`. It defaults to
`10950` or `30 * 365` or `30 years`.

<a name="Build_Actions" class="injected"></a>

Expand Down
5 changes: 5 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,9 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
<AndroidSdkToolsVersion Condition="'$(AndroidSdkToolsVersion)' == ''">26.1.1</AndroidSdkToolsVersion>
<AndroidNdkVersion Condition="'$(AndroidNdkVersion)' == ''">16.1</AndroidNdkVersion>

<AndroidDebugKeyAlgorithm Condition=" '$(AndroidDebugKeyAlgorithm)' == '' ">RSA</AndroidDebugKeyAlgorithm>
<AndroidDebugKeyValidity Condition=" '$(AndroidDebugKeyValidity)' == '' ">10950</AndroidDebugKeyValidity>

<!-- Obsolete -->
<AndroidGdbDebugServer>None</AndroidGdbDebugServer>

Expand Down Expand Up @@ -2515,6 +2518,8 @@ because xbuild doesn't support framework reference assemblies.
KeyAlias="androiddebugkey"
KeyPass="android"
StorePass="android"
KeyAlgorithm="$(AndroidDebugKeyAlgorithm)"
Validity="$(AndroidDebugKeyValidity)"
ToolPath="$(KeytoolToolPath)"
ToolExe="$(KeytoolToolExe)"
Command="-genkeypair"
Expand Down