Skip to content

[Xamarin.Android.Build.Tasks] Install FSharp.Core 4.3.1 #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dellis1972 merged 1 commit into from
Mar 20, 2018
Merged

[Xamarin.Android.Build.Tasks] Install FSharp.Core 4.3.1 #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Xamarin.Android.Build.Tasks.tpnitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@

<!-- External dependencies from `Xamarin.Android.Build.Tasks/packages.config` -->
<ItemGroup Condition=" '$(TpnIncludeExternalDependencies)' == 'True' ">
<ThirdPartyNotice Include="fsharp/fsharp">
<LicenseFile>$(MSBuildThisFileDirectory)\..\build-tools\license-data\Apache-2.0.txt</LicenseFile>
<SourceUrl>https://github.com/fsharp/fsharp/</SourceUrl>
</ThirdPartyNotice>
<ThirdPartyNotice Include="fsprojects/FSharp.Compiler.CodeDom">
<LicenseText>
This is free and unencumbered software released into the public domain.
Expand Down
3 changes: 3 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
<Reference Include="FSharp.Compiler.CodeDom">
<HintPath>..\..\packages\FSharp.Compiler.CodeDom.1.0.0.1\lib\net40\FSharp.Compiler.CodeDom.dll</HintPath>
</Reference>
<Reference Include="FSharp.Core">
<HintPath>..\..\packages\FSharp.Core.3.1.2.5\lib\net40\FSharp.Core.dll</HintPath>
Copy link
Contributor

@dellis1972 dellis1972 Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 3.1.2.5 the right version? 4.3.4 is the current on nuget.org

Copy link
Contributor Author

@jonpryor jonpryor Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need assembly version 4.3.1, and NuGet package 3.1.2.5 is the last one to provide that; laster NuGet packages provide version 4.4.0.

So we either use this NuGet package, or I figure out how to do binding redirects. :-/

</Reference>
</ItemGroup>
<ItemGroup>
<Compile Include="$(IntermediateOutputPath)Profile.g.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/Xamarin.Android.Build.Tasks/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="FSharp.Compiler.CodeDom" version="1.0.0.1" targetFramework="net45" />
<package id="FSharp.Core" version="3.1.2.5" targetFramework="net451" />
<package id="Irony" version="0.9.1" targetFramework="net45" />
</packages>