Move a couple of soure build scripts from build-tools to src.#1495
Merged
jonpryor merged 1 commit intodotnet:masterfrom Mar 30, 2018
Merged
Move a couple of soure build scripts from build-tools to src.#1495jonpryor merged 1 commit intodotnet:masterfrom
jonpryor merged 1 commit intodotnet:masterfrom
Conversation
dotnet#1489 (comment) complains that the additions of new sources to build-tools is wrong because they are not "build-tools", mentioning that the existing sources are wrong. Wait, then, why not fix it right now. Therefore, fixing this. `mono-runtimes`, `libzip` and `libzip-windows` are moved to src.
atsushieno
requested review from
dellis1972,
grendello and
jonpryor
and removed request for
dellis1972,
grendello and
jonpryor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1489 (comment)
complains that the additions of new sources to build-tools is wrong because
they are not "build-tools", mentioning that the existing sources are wrong.
Wait, then, why not fix it right now.
Therefore, fixing this.
mono-runtimes,libzipandlibzip-windowsare moved to src.