-
Notifications
You must be signed in to change notification settings - Fork 565
[xa-prep-tasks] Use the Mono bundle #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <UsingTask AssemblyFile="..\..\bin\Build$(Configuration)\xa-prep-tasks.dll" TaskName="Xamarin.Android.BuildTools.PrepTasks.GitCommitHash" /> | ||
| <Target Name="_GetHashes"> | ||
| <GitCommitHash | ||
| WorkingDirectory="$(LibZipSourceFullPath)" | ||
| ToolPath="$(GitToolPath)" | ||
| ToolExe="$(GitToolExe)"> | ||
| <Output TaskParameter="AbbreviatedCommitHash" PropertyName="_LibZipHash" /> | ||
| </GitCommitHash> | ||
| <GitCommitHash | ||
| WorkingDirectory="$(LlvmSourceFullPath)" | ||
| ToolPath="$(GitToolPath)" | ||
| ToolExe="$(GitToolExe)"> | ||
| <Output TaskParameter="AbbreviatedCommitHash" PropertyName="_LlvmHash" /> | ||
| </GitCommitHash> | ||
| <GitCommitHash | ||
| WorkingDirectory="$(MonoSourceFullPath)" | ||
| ToolPath="$(GitToolPath)" | ||
| ToolExe="$(GitToolExe)"> | ||
| <Output TaskParameter="AbbreviatedCommitHash" PropertyName="_MonoHash" /> | ||
| </GitCommitHash> | ||
| </Target> | ||
| <Target Name="GetBundleFileName" | ||
| DependsOnTargets="_GetHashes"> | ||
| <PropertyGroup> | ||
| <XABundleFileName>bundle-v2-$(Configuration)-$(HostOS)-libzip=$(_LibZipHash),llvm=$(_LlvmHash),mono=$(_MonoHash).zip</XABundleFileName> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where else is
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| </PropertyGroup> | ||
| </Target> | ||
| </Project> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this kind of {x,ms}build invocation, to be honest. It's convenient if it works, but if it breaks... The error output of msbuild is mangled and next to impossible to read, also it gets interpreted by shell as a set of commands. Maybe (not as part of this PR) we should have a wrapper script for such one-liners that will properly check the exit status of the command as well as log and process its output.