[mono-runtimes] Bundle Consts.cs, use correct opt.exe install location #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#162 PR dotnet#162 tries to use the mono bundle (fbfd676) to avoid rebuilding mono on subsequent builds (when the mono commit hasn't changed), in order to speed up the Jenkins build process (currently tracking at ~3.5 *hours* for a non-PR build...) [PR dotnet#162 currently fails][0] when building `src/Mono.Data.Sqlite`: CSC: error CS2001: Source file `/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/external/mono/mcs/build/common/Consts.cs' could not be found Fix this error by copying `external/mono/mcs/build/common/Consts.cs` into `bin/$(Configuration)/include`, and updating the `Consts.cs` references within `Mono.Data.Sqlite.csproj` and `Mono.Posix.csproj` so that they'll use the `include` copy. This should allow us to use the bundle to build these projects. Additionally, `llc.exe` and `opt.exe` are installed into `$prefix/bin`, which isn't correct; `$prefix/bin` as a construct doesn't exist on Windows. Install these into `$prefix/lib/mandroid`. Update the bundle version to note these bundle changes. [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android-pr-builder/67/console
radekdoulik
pushed a commit
to radekdoulik/xamarin-android
that referenced
this pull request
Aug 18, 2016
dotnet#165) Context: dotnet#162 PR dotnet#162 tries to use the mono bundle (fbfd676) to avoid rebuilding mono on subsequent builds (when the mono commit hasn't changed), in order to speed up the Jenkins build process (currently tracking at ~3.5 *hours* for a non-PR build...) [PR dotnet#162 currently fails][0] when building `src/Mono.Data.Sqlite`: CSC: error CS2001: Source file `/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/external/mono/mcs/build/common/Consts.cs' could not be found Fix this error by copying `external/mono/mcs/build/common/Consts.cs` into `bin/$(Configuration)/include`, and updating the `Consts.cs` references within `Mono.Data.Sqlite.csproj` and `Mono.Posix.csproj` so that they'll use the `include` copy. This should allow us to use the bundle to build these projects. Additionally, `llc.exe` and `opt.exe` are installed into `$prefix/bin`, which isn't correct; `$prefix/bin` as a construct doesn't exist on Windows. Install these into `$prefix/lib/mandroid`. Update the bundle version to note these bundle changes. [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android-pr-builder/67/console
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=56653 Android's Zygote process, responsible for starting and initializing of every app as well as catching any application crashes (exceptions not handled by the app, most of the time), special-cases application exceptions of types java.lang.Error and java.lang.Exception (and their derivatives) and this may cause issues with automatic crash reporting recently added to the Google's Developer Console. The automatically collected reports do not contain the full trace of exceptions that *don't* inherit from Exception or Error. Change the base class of JavaProxyThrowable to Error so that if it reaches the Zygote handler the full stack trace will be provided.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #162
PR #162 tries to use the mono bundle (fbfd676) to avoid rebuilding
mono on subsequent builds (when the mono commit hasn't changed), in
order to speed up the Jenkins build process (currently tracking at
~3.5 hours for a non-PR build...)
PR #162 currently fails when building
src/Mono.Data.Sqlite:Fix this error by copying
external/mono/mcs/build/common/Consts.csinto
bin/$(Configuration)/include, and updating theConsts.csreferences within
Mono.Data.Sqlite.csprojandMono.Posix.csprojsothat they'll use the
includecopy.This should allow us to use the bundle to build these projects.
Additionally,
llc.exeandopt.exeare installed into$prefix/bin, which isn't correct;$prefix/binas a constructdoesn't exist on Windows. Install these into
$prefix/lib/mandroid.Update the bundle version to note these bundle changes.