[Linux] Add submodules to cross-build libmonodroid for Windows #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
changed the title
jonpryor
reviewed
May 25, 2018
| @@ -0,0 +1,29 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
Contributor
There was a problem hiding this comment.
I think this file should go into build-tools, not src. The outputs of this project will not be redistributed; instead, they'll be used in order to build e.g. libmono, which is redistributed.
jonpryor
reviewed
May 25, 2018
Configuration.props
Outdated
| <AutoProvision Condition=" '$(AutoProvision)' == '' ">False</AutoProvision> | ||
| <AutoProvisionUsesSudo Condition=" '$(AutoProvisionUsesSudo)' == '' ">False</AutoProvisionUsesSudo> | ||
| <XAInstallPrefix Condition=" '$(XAInstallPrefix)' == '' ">$(MSBuildThisFileDirectory)\bin\$(Configuration)\lib\xamarin.android\</XAInstallPrefix> | ||
| <LinuxMingwDependenciesRootDirectory Condition=" '$(LinuxMingwDependenciesRootDirectory)' == '' ">$(MSBuildThisFileDirectory)\bin\$(Configuration)\linux-mingw-deps</LinuxMingwDependenciesRootDirectory> |
Contributor
There was a problem hiding this comment.
I believe these outputs should go into bin/Build$(Configuration), not bin/$(Configuration).
Adds two components that are required by libmonodroid but not provided with the packaged mingw on Linux (they are part of the mxe build on macOS): * dlfcn-win32: implementation of dlopen + friends for Windows * mman-win32: implementation of mman.h (mmap and friends) for Windows This allows to perform a full build of Xamarin.Android with cross build for Windows on Linux
grendello
force-pushed
the
linux-mingw-build
branch
from
4d09726 to
2ee99a7
Compare
grendello
added
do-not-merge
We shouldn't intermix tabs & spaces in XML files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two components that are required by libmonodroid but not provided with the
packaged mingw on Linux (they are part of the mxe build on macOS):
This allows to perform a full build of Xamarin.Android with cross build for Windows on Linux