Skip to content

Remove armeabi from build. #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonpryor merged 1 commit into from
Jul 26, 2018
Merged

Remove armeabi from build. #1995

jonpryor merged 1 commit into from
Jul 26, 2018

Conversation

@atsushieno
Copy link
Contributor

@atsushieno atsushieno commented Jul 24, 2018

Starting with Android NDK r17, armeabi is removed, meaning that we
cannot build anything with armeabi anymore.

seealso: dotnet/java-interop#346

@atsushieno
Remove armeabi from build.
a4b97b5 
Starting with Android NDK r17, armeabi is *removed*, meaning that we
cannot build anything with armeabi anymore.

seealso: dotnet/java-interop#346
@atsushieno atsushieno mentioned this pull request Jul 24, 2018
Closed
@jonpryor jonpryor merged commit e89ba56 into dotnet:master Jul 26, 2018
@dellis1972
Copy link
Contributor

dellis1972 commented Jul 27, 2018

@jonpryor @atsushieno how will this effect users who have armeabi as on of the supported Abis for their project? Shouldn't we be removing it? Also we need to loop in the IDE teams to remove this as an option from the IDE. //cc @sgmunn @joj

jonpryor added a commit that referenced this pull request Jul 27, 2018
@jonpryor
Revert "[build] Stop building armeabi libraries (#1995)"
175f514 
This reverts commit e89ba56.
jonpryor added a commit that referenced this pull request Jul 27, 2018
@jonpryor
Revert "[build] Stop building armeabi libraries (#1995)"
09bc6ef 
This reverts commit e89ba56.

Commit e89ba56 [broke the build][0]:

	  MONO_PATH=/Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/tools/offsets-tool/CppSharp/osx_32 mono --arch=32 /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/tools/offsets-tool/MonoAotOffsetsDumper.exe --android-ndk="/Users/builder/android-toolchain/ndk" --mono="/Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono" --monodroid="/Users/builder/jenkins/workspace/xamarin-android/xamarin-android/" --abi="armv5-none-linux-androideabi" --targetdir="/Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/sdks/builds/android-armeabi-debug" --out="/Users/builder/jenkins/workspace/xamarin-android/xamarin-android/src/mono-runtimes/obj/Debug//cross-arm"

	  Processing triple: armv5-none-linux-androideabi

	  Unhandled Exception:
	  System.Exception: Could not find the target build directory: /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/sdks/builds/android-armeabi-debug
	    at CppSharp.MonoAotOffsetsDumper.SetupMono (CppSharp.Driver driver, CppSharp.MonoAotOffsetsDumper+Target target) [0x00128] in <2f8bf518c8bd43fb8ac2a2d284bd85a5>:0
	    at CppSharp.MonoAotOffsetsDumper.Setup (CppSharp.Driver driver, CppSharp.MonoAotOffsetsDumper+Target target) [0x000a2] in <2f8bf518c8bd43fb8ac2a2d284bd85a5>:0
	    at CppSharp.MonoAotOffsetsDumper.Main (System.String[] args) [0x00118] in <2f8bf518c8bd43fb8ac2a2d284bd85a5>:0

The Mono SDKs build step still requires armv5 support, so we can't
stop building `armeabi` libraries until mono stops requiring them.

[0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/1107/
@jonpryor
Copy link
Contributor

jonpryor commented Jul 27, 2018

@dellis1972: excellent points: we need to do something, and the IDE teams should remove the armeabi option at some point in time.

@jonpryor
Copy link
Contributor

jonpryor commented Jul 27, 2018

Also, I had to revert this PR because mono didn't like it. :-(

@atsushieno
Copy link
Contributor Author

atsushieno commented Jul 27, 2018

Technically "there are no Android 4+ devices which support armeabi but not armeabi-v7a, so you can safely drop armeabi". https://stackoverflow.com/questions/28926101/is-it-safe-to-support-only-armeabi-v7a-for-android-4-and-above

Projects which specify armeabi as build target but not armeabi-v7a can be either safely migrated to armeabi-v7a, or notify them as "your project is out of Android platform scope and need to migrate by removing armeabi and switch to armeabi-v7a".

@sgmunn
Copy link

sgmunn commented Jul 30, 2018

@jonpryor can you create user stories tracking removal of armabi option and desired timeframe?

@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dellis1972 dellis1972 Awaiting requested review from dellis1972

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atsushieno @dellis1972 @jonpryor @sgmunn