Skip to content

[Xamarin.Android.Build.Tasks] call Disposable () for assembly and pass ReadWrite #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 1 commit into from
Sep 26, 2016
Merged

[Xamarin.Android.Build.Tasks] call Disposable () for assembly and pass ReadWrite #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Xamarin.Android.Build.Tasks/Tasks/RemoveRegisterAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ public override bool Execute ()

// Find Mono.Android.dll
var mono_android = ShrunkFrameworkAssemblies.First (f => Path.GetFileNameWithoutExtension (f.ItemSpec) == "Mono.Android").ItemSpec;
var assembly = AssemblyDefinition.ReadAssembly (mono_android);
using (var assembly = AssemblyDefinition.ReadAssembly (mono_android, new ReaderParameters { ReadWrite = true })) {
// Strip out [Register] attributes
foreach (TypeDefinition type in assembly.MainModule.Types)
ProcessType (type);

// Strip out [Register] attributes
foreach (TypeDefinition type in assembly.MainModule.Types)
ProcessType (type);

assembly.Write (mono_android);
assembly.Write ();
}

return true;
}
Expand Down