Fix Xamarin.Android.sln build with xbuild #4
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 22, 2016 18:03
This is required because of a bug in xbuild. It tries to look for the Java.Interop projects which are referenced from the other projects, in the sln itself, because it needs to figure out a build order for *all* the projects. It should probably allow projects not being present in sln and build them via the reference.
- Build _GenerateJavaCallableWrappers *after* CoreBuild instead of CoreCompile. This is because it depends on Mono.Android.dll being in the OutputDir, but the *copy* to that directory happens *after* CoreCompile. This was hit when Mono.Android.dll would get compiled to obj/Debug/Mono.Android.dll , but before it can be copied, jcw-gen is run which expects Mono.Android.dll in the bin/Debug, thus breaking the build. - Paths passed to jcw-gen.exe as arguments should be relative to the directory containing jcw-gen.exe or should be absolute.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.