[Build] Bump Xamarin.LibZipSharp to 1.0.7#4147
Merged
dellis1972 merged 5 commits intodotnet:masterfrom Jan 21, 2020
Merged
Conversation
Fixes dotnet#4100 The version of libzip.so we shipped for linux in 1.0.6 had a dependency on libcrypto.so.1.1. Some linux based systems only ship with libcrypto.so.1.0. As a result Xamarin.Android would not build and we give the following error. error MSB4018: System.DllNotFoundException: lib64/libzip.so assembly Verison 1.0.7 if Xamarin.LibZipSharp fixes this issue by statically linking libcrypto (and other dependencies) into the dynamic library. This should allow Xamarin.Android to build and run on those systems which does not include libcrypto or have an older version.
grendello
approved these changes
Jan 20, 2020
Contributor
|
I just tried the branch on Ubuntu 16.04 and can confirm that it removes the DllNotFoundException. Thanks for the fix! Note that the build runs into other errors later on. I'll report that in a separate issue ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4100
The version of libzip.so we shipped for linux in
1.0.6 had a dependency on libcrypto.so.1.1. Some
linux based systems only ship with libcrypto.so.1.0.
As a result Xamarin.Android would not build and we give
the following error.
Verison 1.0.7 if Xamarin.LibZipSharp fixes this issue by
statically linking libcrypto (and other dependencies) into the
dynamic library. This should allow Xamarin.Android to build and
run on those systems which does not include libcrypto or have
an older version.
This PR reworks the source a bit so we define the LibZipSharp version in ONE place.
Both the all the csproj and targets files include
Configuration.propsin them. So itmakes sense to place the version there as an MSBuild Property. We then need to update
the Third Party Notices code to pick up that MSBuild property rather than hard coding the
version into the C# code. This way we only need to update the version in one place going
forward.