Skip to content

Conversation

@jonathanpeppers
Copy link
Member

Context: https://github.com/dotnet/installer

This is still a "master" build, they are just using the rc1 name after preview7.

This may break some tests using Xamarin.Forms, we'll see what happens.

Context: https://github.com/dotnet/installer

This is still a "master" build, they are just using the `rc1` name after `preview7`.

This may break some tests using Xamarin.Forms, we'll see what happens.
@jonathanpeppers jonathanpeppers marked this pull request as ready for review July 16, 2020 21:14
@jonathanpeppers
Copy link
Member Author

It looks like everything worked, I was afraid this test might fail, but it doesn't use a Forms project:

https://github.com/xamarin/xamarin-android/blob/9c880983914e2dbc3f384dea16b5351696732682/tests/MSBuildDeviceIntegration/Tests/XASdkDeployTests.cs#L51-L59

I'll make other versions of this test down the road.

@jonathanpeppers
Copy link
Member Author

Closing in favor of #5007

@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant