[Xamarin.Android.Build.Tests] Move tests into a Shared Project so they can be reused upstream. #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y can be reused upstream. Rather than have all the msbuild tests in an assembly this commit moves them into a shared project. This means the source code for the tests can be easily reused upstream. It also means we can make use of things like partial classes to change the tests depending on which repo we are running them from. For example having tests in this repo only run in Release mode but have both Release and Debug upstream.
jonpryor
added a commit
that referenced
this pull request
Nov 8, 2019
Changes: dotnet/java-interop@315968e...47f47bc Context: #3844 * dotnet/java-interop@47f47bc: [generator] Ensure all usage of parameter names are escaped the same (#506) * dotnet/java-interop@dc680d0: [Java.Interop.Tools.JavaCallableWrappers] remove all usage of MD5 (#510)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Nov 19, 2019
Changes: dotnet/java-interop@baf43b0...166a6c9 Fixes: dotnet/java-interop#519 * dotnet/java-interop@166a6c9: [Java.Interop-Tests] Remove Reflection from JavaPrimitiveArrayContract (dotnet#521) * dotnet/java-interop@09083d9: [generator] Support empty package names (dotnet#520) * dotnet/java-interop@af3dc77: [build] Set up YAML Azure pipeline. (dotnet#516) * dotnet/java-interop@8602581: [java-interop] Enabling -fPIC on Linux build - part 2 (dotnet#518) * dotnet/java-interop@ff3081d: [build] Migrate library projects to SDK style + netstandard2.0 (dotnet#507) * dotnet/java-interop@f5d29c3: [generator] Ensure all usage of parameter names are escaped the same (dotnet#506) * dotnet/java-interop@17cdf54: Add vscode files so we can build/debug/test from inside the vscode ide (dotnet#513)
jonpryor
added a commit
that referenced
this pull request
Nov 20, 2019
Changes: dotnet/java-interop@baf43b0...166a6c9 Fixes: dotnet/java-interop#519 * dotnet/java-interop@166a6c9: [Java.Interop-Tests] Remove Reflection from JavaPrimitiveArrayContract (#521) * dotnet/java-interop@09083d9: [generator] Support empty package names (#520) * dotnet/java-interop@af3dc77: [build] Set up YAML Azure pipeline. (#516) * dotnet/java-interop@8602581: [java-interop] Enabling -fPIC on Linux build - part 2 (#518) * dotnet/java-interop@ff3081d: [build] Migrate library projects to SDK style + netstandard2.0 (#507) * dotnet/java-interop@f5d29c3: [generator] Ensure all usage of parameter names are escaped the same (#506) * dotnet/java-interop@17cdf54: Add vscode files so we can build/debug/test from inside the vscode ide (#513)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than have all the msbuild tests in an assembly this commit
moves them into a shared project. This means the source code for
the tests can be easily reused upstream. It also means we can make
use of things like partial classes to change the tests depending on
which repo we are running them from. For example having tests in this
repo only run in Release mode but have both Release and Debug upstream.