[Xamarin.Android.Build.Tasks] @(AndroidLibrary) for all project types#5372
Merged
jonpryor merged 1 commit intodotnet:masterfrom Dec 9, 2020
Merged
Conversation
jonathanpeppers
force-pushed
the
dotnet-availableitemnames
branch
2 times, most recently
from
8868293 to
1aa70d8
Compare
dellis1972
approved these changes
Dec 7, 2020
Member
Author
|
The one test failure is: @dellis1972 if you want to see the Maybe a random failure? |
Contributor
Related to https://github.com/xamarin/monodroid/pull/1139/files#diff-7852ba3521b112c065b28e7d98b1b05843c2215fc0e28300264bcdb7bf311780R136 . The |
Contributor
|
The problem is in |
Contributor
|
ok looks like the main issue here is we probably need to use a different package like |
jonpryor
reviewed
Dec 8, 2020
jonpryor
reviewed
Dec 8, 2020
|
|
||
| ## EmbeddedReferenceJar | ||
|
|
||
| In a Xamarin.Android binding project, the **EmbeddedReferenceJar** |
Contributor
There was a problem hiding this comment.
Ditto here, etc., etc. We can link to build properties & item group docs now! Let's use it.
Member
Author
There was a problem hiding this comment.
I did this everywhere now, except for when they refer to themselves.
jonpryor
reviewed
Dec 8, 2020
jonathanpeppers
force-pushed
the
dotnet-availableitemnames
branch
from
1aa70d8 to
f12dbce
Compare
Fixes: dotnet#5357 The new `@(AndroidLibrary)` item group can now be used in "legacy" Xamarin.Android: <AndroidLibrary Include="foo.jar" /> <AndroidLibrary Include="bar.aar" /> * Application and class library projects: * `foo.jar` maps to `AndroidJavaLibrary` * `bar.aar` maps to `AndroidAarLibrary` * Java binding projects: * `foo.jar` maps to `EmbeddedJar` * `foo.jar` maps to `EmbeddedReferenceJar` if `Bind="false"` metadata is added * `bar.aar` maps to `LibraryProjectZip` * Additionally: * `@(AndroidNativeLibrary)` now will be used for native libraries. You can use `@(AndroidNativeLibrary)` instead of `@(EmbeddedNativeLibrary)`. All `@(AvailableItemNames)` are now defined in a single `Xamarin.Android.AndroidItems.targets` that is imported by all project types: both legacy apps, libraries, and bindings and .NET 6. I documented the changes to the item groups, some of which didn't have documentation at all. I updated a few binding tests to use `@(AndroidLibrary)`. There are still several more tests using the old item names.
jonathanpeppers
force-pushed
the
dotnet-availableitemnames
branch
from
f12dbce to
8cca282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5357
The new
@(AndroidLibrary)item group can now be used in "legacy"Xamarin.Android:
foo.jarmaps toAndroidJavaLibrarybar.aarmaps toAndroidAarLibraryfoo.jarmaps toEmbeddedJarfoo.jarmaps toEmbeddedReferenceJarifBind="false"metadata is addedbar.aarmaps toLibraryProjectZip@(AndroidNativeLibrary)now will be used for native libraries.You can use
@(AndroidNativeLibrary)instead of@(EmbeddedNativeLibrary).All
@(AvailableItemNames)are now defined in a singleXamarin.Android.AndroidItems.targetsthat is imported by all projecttypes: both legacy apps, libraries, and bindings and .NET 6.
I documented the changes to the item groups, some of which didn't have
documentation at all.
I updated a few binding tests to use
@(AndroidLibrary). There arestill several more tests using the old item names.