[build] set $(ProduceReferenceAssemblyInOutDir)=True #6744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://docs.microsoft.com/dotnet/core/compatibility/sdk/6.0/write-reference-assemblies-to-obj Context: dotnet/msbuild#7355 Context: dotnet/java-interop#949 Using the latest internal builds of Visual Studio, you hit the build error when building xamarin-android: error MSB4018: The "CreateFrameworkListFile" task failed unexpectedly. [C:\src\xamarin-android\build-tools\create-packs\Microsoft.Android.Ref.proj] [C:\src\xamarin-android\build-tools\create-packs\Microsoft.Android.Sdk.proj] error MSB4018: System.IO.FileNotFoundException: Could not find file 'C:\src\xamarin-android\bin\Release\lib\xamarin.android\xbuild-frameworks\Microsoft.Android\net6.0-android32\ref\Mono.Android.dll'. This was a breaking change in MSBuild: > ### Old behavior > Since reference assemblies were added, the .NET SDK has written > reference assemblies to the `ref` directory in the `OutDir` > directory of the compilation. > > ### New behavior > Now, reference assemblies are written to the `refint` directory of > the `IntermediateOutputPath` directory by default, like many other > intermediate artifacts. > > ### Reason for change > Reference assemblies are generally not run-time assets, and so don't > belong in the `OutDir` directory by default. Since we *are* using the reference assembly as build output, I think we *should* put the file in `bin`. Let's set `$(ProduceReferenceAssemblyInOutDir)`=True to get the old behavior. I could not figure out how to use `$(TargetRefPath)` here, as different projects are using the files than producing them... If the same project was building `Mono.Android.dll` as packing it, we could use that property and not have to know if the file is in `bin` or `obj`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://docs.microsoft.com/dotnet/core/compatibility/sdk/6.0/write-reference-assemblies-to-obj
Context: dotnet/msbuild#7355
Context: dotnet/java-interop#949
Using the latest internal builds of Visual Studio, you hit the build
error when building xamarin-android:
This was a breaking change in MSBuild:
Since we are using the reference assembly as build output, I think
we should put the file in
bin.Let's set
$(ProduceReferenceAssemblyInOutDir)=True to get theold behavior.
I could not figure out how to use
$(TargetRefPath)here, asdifferent projects are using the files than producing them... If the
same project was building
Mono.Android.dllas packing it, we coulduse that property and not have to know if the file is in
binorobj.