Skip to content

Conversation

@akoeplinger
Copy link
Member

Reverts #6953

The fix for this issue is backported to dotnet/runtime 6.0 now so we can revert the workaround.

@akoeplinger akoeplinger requested a review from jonpryor as a code owner June 22, 2022 13:55
@akoeplinger
Copy link
Member Author

@jonpryor ping

@jonpryor
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonpryor
Copy link
Contributor

@akoeplinger: sorry for the delay.

Do you have a link handy to the dotnet/runtime commit which contains the fix?

@akoeplinger
Copy link
Member Author

@jonpryor dotnet/runtime#68235 for main and dotnet/runtime#68265 for the 6.0 backport

@jonathanpeppers
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I reran two tests that had some failures.

@jonpryor jonpryor force-pushed the revert-6953-workaround-firstchanceexception branch from b74530b to 3f01aca Compare July 19, 2022 19:17
@jonpryor
Copy link
Contributor

Windows build stopped building. Rebased on main, force-pushed.

@jonpryor jonpryor merged commit 29ea53a into main Jul 20, 2022
@jonpryor jonpryor deleted the revert-6953-workaround-firstchanceexception branch July 20, 2022 23:18
@jonathanpeppers
Copy link
Member

This is good for .NET 7/main. Just FYI, we should be wary backporting this to .NET 6 -- maybe we don't even need to.

We'll need to make sure the dotnet/runtime schedule matches up with ours, if we do backport.

@akoeplinger
Copy link
Member Author

Yeah backporting to .NET6 isn't really needed at this point I think since the workaround works and the only impact is the FirstChanceExceptionEventArgs type being preserved unconditionally rather than only when it's used.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants