Skip to content

Conversation

@pjcollins
Copy link
Member

Commit 475b912 improved Android SDK dependency provisioning steps by
combining the install of emulator and non emulator related dependencies.
These changes also moved emulator component provisioning to a step that
includes preview .NET SDK provisioning. In the nightly build this step
was running after we installed our workload packages, and our workload
install would be removed as part of SDK re-provisioning. This caused
~all of our nightly tests to fail with:

/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/sdk/8.0.100-preview.6.23276.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: android

or

System.IO.DirectoryNotFoundException : Unable to locate a Microsoft.Android.Sdk in either '/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/packs' or '/Users/runner/work/1/s/xamarin-android/bin/Release/lib/packs'.

Fix this by updating the nightly build to bring in the handful of recent
improvements that were made to our to emulator test jobs. Emulator
component provisioning will now happen before .NET SDK and workload
installation.

The localization test job template has also been removed as it is no
longer in use.

pjcollins added 2 commits June 6, 2023 16:46
Commit 475b912 improved Android SDK dependency provisioning steps by
combining the install of emulator and non emulator related dependencies.
These changes also moved emulator component provisioning to a step that
includes preview .NET SDK provisioning.  In the nightly build this step
was running _after_ we installed our workload packages, and our workload
install would be removed as part of SDK re-provisioning.  This caused
~all of our nightly tests to fail with:

    /Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/sdk/8.0.100-preview.6.23276.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: android

or

    System.IO.DirectoryNotFoundException : Unable to locate a Microsoft.Android.Sdk in either '/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/packs' or '/Users/runner/work/1/s/xamarin-android/bin/Release/lib/packs'.

Fix this by updating the nightly build to bring in the handful of recent
improvements that were made to our to emulator test jobs.  Emulator
component provisioning will now happen _before_ .NET SDK and workload
installation.

The localization test job template has also been removed as it is no
longer in use.
@pjcollins
Copy link
Member Author

@pjcollins
Copy link
Member Author

Probably still some reliability issues to work in individual tests out but this is working as expected.

@pjcollins pjcollins marked this pull request as ready for review June 6, 2023 22:34
@pjcollins pjcollins requested a review from jonpryor as a code owner June 6, 2023 22:34
@pjcollins pjcollins requested a review from jpobst June 6, 2023 22:34
@pjcollins pjcollins merged commit 1cfee36 into main Jun 7, 2023
@pjcollins pjcollins deleted the dev/pjc/fix-nightly-provision branch June 7, 2023 17:28
grendello added a commit to grendello/xamarin-android that referenced this pull request Jun 12, 2023
* main:
  LEGO: Merge pull request 8119
  [build] Bump `$(XABuildToolsVersion)`=34 (dotnet#8118)
  [Xamarin.Android.Build.Tasks] missing resource error handling (dotnet#8066)
  [CI] Allow MSBuild test stages to run in the megapipeline (dotnet#8033)
  [ci] Fix nightly test environment provisioning (dotnet#8113)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants