Skip to content

[Mono.Android] Add missing [Flags] attribute for generated enums. #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 1 commit into from
Sep 1, 2023
Merged

[Mono.Android] Add missing [Flags] attribute for generated enums. #8310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions src/Mono.Android/PublicAPI/API-34/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6918,7 +6918,7 @@ Android.Appwidget.AppWidgetProviderInfo.WidgetCategory.set -> void
Android.Appwidget.AppWidgetProviderInfo.WidgetFeatures.get -> Android.Appwidget.WidgetFeatures
Android.Appwidget.AppWidgetProviderInfo.WidgetFeatures.set -> void
Android.Appwidget.ResizeMode
Android.Appwidget.ResizeMode.Both = 3 -> Android.Appwidget.ResizeMode
Android.Appwidget.ResizeMode.Both = Android.Appwidget.ResizeMode.Horizontal | Android.Appwidget.ResizeMode.Vertical -> Android.Appwidget.ResizeMode
Copy link
Contributor

@jonpryor jonpryor Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes for an "interesting" change: using [Flags] means that PublicAPI.Unshipped.txt. has "more readable" output, using named constants instead of underlying integers. Nice!

Alas, we can't use "presence of a raw value in PublicAPI.Unshipped.txt as an "alternate verification", because "used of named constants" only happens for |ed values.

Android.Appwidget.ResizeMode.Horizontal = 1 -> Android.Appwidget.ResizeMode
Android.Appwidget.ResizeMode.None = 0 -> Android.Appwidget.ResizeMode
Android.Appwidget.ResizeMode.Vertical = 2 -> Android.Appwidget.ResizeMode
Expand Down Expand Up @@ -9694,7 +9694,7 @@ Android.Content.PM.Protection.MaskBase = 15 -> Android.Content.PM.Protection
Android.Content.PM.Protection.MaskFlags = 65520 -> Android.Content.PM.Protection
Android.Content.PM.Protection.Normal = 0 -> Android.Content.PM.Protection
Android.Content.PM.Protection.Signature = 2 -> Android.Content.PM.Protection
Android.Content.PM.Protection.SignatureOrSystem = 3 -> Android.Content.PM.Protection
Android.Content.PM.Protection.SignatureOrSystem = Android.Content.PM.Protection.Dangerous | Android.Content.PM.Protection.Signature -> Android.Content.PM.Protection
Android.Content.PM.ProviderInfo
Android.Content.PM.ProviderInfo.Authority.get -> string?
Android.Content.PM.ProviderInfo.Authority.set -> void
Expand Down Expand Up @@ -9827,7 +9827,7 @@ Android.Content.PM.SharedLibraryInfo.WriteToParcel(Android.OS.Parcel? parcel, An
Android.Content.PM.SharedLibraryType
Android.Content.PM.SharedLibraryType.Builtin = 0 -> Android.Content.PM.SharedLibraryType
Android.Content.PM.SharedLibraryType.Dynamic = 1 -> Android.Content.PM.SharedLibraryType
Android.Content.PM.SharedLibraryType.SdkPackage = 3 -> Android.Content.PM.SharedLibraryType
Android.Content.PM.SharedLibraryType.SdkPackage = Android.Content.PM.SharedLibraryType.Dynamic | Android.Content.PM.SharedLibraryType.Static -> Android.Content.PM.SharedLibraryType
Android.Content.PM.SharedLibraryType.Static = 2 -> Android.Content.PM.SharedLibraryType
Android.Content.PM.ShortcutDisabledReason
Android.Content.PM.ShortcutDisabledReason.AppChanged = 2 -> Android.Content.PM.ShortcutDisabledReason
Expand Down Expand Up @@ -12674,7 +12674,7 @@ Android.Hardware.Camera2.CameraExtensionTypes.Automatic = 0 -> Android.Hardware.
Android.Hardware.Camera2.CameraExtensionTypes.Beauty = 1 -> Android.Hardware.Camera2.CameraExtensionTypes
Android.Hardware.Camera2.CameraExtensionTypes.Bokeh = 2 -> Android.Hardware.Camera2.CameraExtensionTypes
Android.Hardware.Camera2.CameraExtensionTypes.FaceRetouch = 1 -> Android.Hardware.Camera2.CameraExtensionTypes
Android.Hardware.Camera2.CameraExtensionTypes.Hdr = 3 -> Android.Hardware.Camera2.CameraExtensionTypes
Android.Hardware.Camera2.CameraExtensionTypes.Hdr = Android.Hardware.Camera2.CameraExtensionTypes.Beauty | Android.Hardware.Camera2.CameraExtensionTypes.Bokeh -> Android.Hardware.Camera2.CameraExtensionTypes
Android.Hardware.Camera2.CameraExtensionTypes.Night = 4 -> Android.Hardware.Camera2.CameraExtensionTypes
Android.Hardware.Camera2.CameraManager
Android.Hardware.Camera2.CameraManager.AvailabilityCallback
Expand Down Expand Up @@ -13300,32 +13300,32 @@ Android.Hardware.ConsumerIrManager.Transmit(int carrierFrequency, int[]? pattern
Android.Hardware.ConsumerIrManager.TransmitAsync(int carrierFrequency, int[]? pattern) -> System.Threading.Tasks.Task!
Android.Hardware.DataSpace
Android.Hardware.DataSpaceRange
Android.Hardware.DataSpaceRange.Extended = 402653184 -> Android.Hardware.DataSpaceRange
Android.Hardware.DataSpaceRange.Extended = Android.Hardware.DataSpaceRange.Full | Android.Hardware.DataSpaceRange.Limited -> Android.Hardware.DataSpaceRange
Android.Hardware.DataSpaceRange.Full = 134217728 -> Android.Hardware.DataSpaceRange
Android.Hardware.DataSpaceRange.Limited = 268435456 -> Android.Hardware.DataSpaceRange
Android.Hardware.DataSpaceRange.Unspecified = 0 -> Android.Hardware.DataSpaceRange
Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.AdobeRgb = 720896 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt2020 = 393216 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt2020ConstantLuminance = 458752 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.AdobeRgb = Android.Hardware.DataSpaceStandard.Bt709 | Android.Hardware.DataSpaceStandard.DciP3 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt2020 = Android.Hardware.DataSpaceStandard.Bt601625 | Android.Hardware.DataSpaceStandard.Bt601525 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt2020ConstantLuminance = Android.Hardware.DataSpaceStandard.Bt709 | Android.Hardware.DataSpaceStandard.Bt2020 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt470m = 524288 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt601525 = 262144 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt601525Unadjusted = 327680 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt601525Unadjusted = Android.Hardware.DataSpaceStandard.Bt709 | Android.Hardware.DataSpaceStandard.Bt601525 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt601625 = 131072 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt601625Unadjusted = 196608 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt601625Unadjusted = Android.Hardware.DataSpaceStandard.Bt709 | Android.Hardware.DataSpaceStandard.Bt601625 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Bt709 = 65536 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.DciP3 = 655360 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Film = 589824 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.DciP3 = Android.Hardware.DataSpaceStandard.Bt601625 | Android.Hardware.DataSpaceStandard.Bt470m -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Film = Android.Hardware.DataSpaceStandard.Bt709 | Android.Hardware.DataSpaceStandard.Bt470m -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceStandard.Unspecified = 0 -> Android.Hardware.DataSpaceStandard
Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Gamma22 = 16777216 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Gamma26 = 20971520 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Gamma28 = 25165824 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Gamma26 = Android.Hardware.DataSpaceTransfer.Linear | Android.Hardware.DataSpaceTransfer.Gamma22 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Gamma28 = Android.Hardware.DataSpaceTransfer.Srgb | Android.Hardware.DataSpaceTransfer.Gamma22 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Hlg = 33554432 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Linear = 4194304 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Smpte170m = 12582912 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Smpte170m = Android.Hardware.DataSpaceTransfer.Linear | Android.Hardware.DataSpaceTransfer.Srgb -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Srgb = 8388608 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.St2084 = 29360128 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.St2084 = Android.Hardware.DataSpaceTransfer.Linear | Android.Hardware.DataSpaceTransfer.Gamma28 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceTransfer.Unspecified = 0 -> Android.Hardware.DataSpaceTransfer
Android.Hardware.DataSpaceType
Android.Hardware.DataSpaceType.AdobeRgb = 151715840 -> Android.Hardware.DataSpaceType
Expand Down Expand Up @@ -18013,7 +18013,7 @@ Android.Media.FaceDetector.FaceDetector(int width, int height, int maxFaces) ->
Android.Media.FaceDetector.FaceDetector(nint javaReference, Android.Runtime.JniHandleOwnership transfer) -> void
Android.Media.FaceDetector.FindFacesAsync(Android.Graphics.Bitmap? bitmap, Android.Media.FaceDetector.Face![]? faces) -> System.Threading.Tasks.Task<int>!
Android.Media.GetDevicesTargets
Android.Media.GetDevicesTargets.All = 3 -> Android.Media.GetDevicesTargets
Android.Media.GetDevicesTargets.All = Android.Media.GetDevicesTargets.Inputs | Android.Media.GetDevicesTargets.Outputs -> Android.Media.GetDevicesTargets
Android.Media.GetDevicesTargets.Inputs = 1 -> Android.Media.GetDevicesTargets
Android.Media.GetDevicesTargets.Outputs = 2 -> Android.Media.GetDevicesTargets
Android.Media.HdcpLevel
Expand Down Expand Up @@ -19841,10 +19841,10 @@ Android.Media.MicrophoneChannelMapping.Processed = 2 -> Android.Media.Microphone
Android.Media.MicrophoneDirection
Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.BiDirectional = 2 -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.Cardioid = 3 -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.Cardioid = Android.Media.MicrophoneDirectionality.Omni | Android.Media.MicrophoneDirectionality.BiDirectional -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.HyperCardioid = 4 -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.Omni = 1 -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.SuperCardioid = 5 -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.SuperCardioid = Android.Media.MicrophoneDirectionality.Omni | Android.Media.MicrophoneDirectionality.HyperCardioid -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneDirectionality.Unknown = 0 -> Android.Media.MicrophoneDirectionality
Android.Media.MicrophoneInfo
Android.Media.MicrophoneInfo.Address.get -> string!
Expand Down Expand Up @@ -19872,7 +19872,7 @@ Android.Media.MicrophoneInfo.Type.get -> Android.Media.AudioDeviceType
Android.Media.MicrophoneLocation
Android.Media.MicrophoneLocation.Mainbody = 1 -> Android.Media.MicrophoneLocation
Android.Media.MicrophoneLocation.MainbodyMovable = 2 -> Android.Media.MicrophoneLocation
Android.Media.MicrophoneLocation.Peripheral = 3 -> Android.Media.MicrophoneLocation
Android.Media.MicrophoneLocation.Peripheral = Android.Media.MicrophoneLocation.Mainbody | Android.Media.MicrophoneLocation.MainbodyMovable -> Android.Media.MicrophoneLocation
Android.Media.MicrophoneLocation.Unknown = 0 -> Android.Media.MicrophoneLocation
Android.Media.Midi.MidiDevice
Android.Media.Midi.MidiDevice.Close() -> void
Expand Down Expand Up @@ -19982,7 +19982,7 @@ Android.Media.OfflineLicenseState.Released = 2 -> Android.Media.OfflineLicenseSt
Android.Media.OfflineLicenseState.Unknown = 0 -> Android.Media.OfflineLicenseState
Android.Media.OfflineLicenseState.Usable = 1 -> Android.Media.OfflineLicenseState
Android.Media.Option
Android.Media.Option.Closest = 3 -> Android.Media.Option
Android.Media.Option.Closest = Android.Media.Option.NextSync | Android.Media.Option.ClosestSync -> Android.Media.Option
Android.Media.Option.ClosestSync = 2 -> Android.Media.Option
Android.Media.Option.NextSync = 1 -> Android.Media.Option
Android.Media.Option.PreviousSync = 0 -> Android.Media.Option
Expand Down Expand Up @@ -30156,7 +30156,7 @@ Android.Telecom.CallAudioRoute.Earpiece = 1 -> Android.Telecom.CallAudioRoute
Android.Telecom.CallAudioRoute.Speaker = 8 -> Android.Telecom.CallAudioRoute
Android.Telecom.CallAudioRoute.Streaming = 16 -> Android.Telecom.CallAudioRoute
Android.Telecom.CallAudioRoute.WiredHeadset = 4 -> Android.Telecom.CallAudioRoute
Android.Telecom.CallAudioRoute.WiredOrEarpiece = 5 -> Android.Telecom.CallAudioRoute
Android.Telecom.CallAudioRoute.WiredOrEarpiece = Android.Telecom.CallAudioRoute.Earpiece | Android.Telecom.CallAudioRoute.WiredHeadset -> Android.Telecom.CallAudioRoute
Android.Telecom.CallAudioState
Android.Telecom.CallAudioState.ActiveBluetoothDevice.get -> Android.Bluetooth.BluetoothDevice?
Android.Telecom.CallAudioState.CallAudioState(bool muted, Android.Telecom.CallAudioRoute route, Android.Telecom.CallAudioRoute supportedRouteMask) -> void
Expand Down Expand Up @@ -30783,7 +30783,7 @@ Android.Telecom.VideoProfile.VideoProfile(Android.Telecom.VideoProfileState vide
Android.Telecom.VideoProfile.VideoProfile(nint javaReference, Android.Runtime.JniHandleOwnership transfer) -> void
Android.Telecom.VideoProfileState
Android.Telecom.VideoProfileState.AudioOnly = 0 -> Android.Telecom.VideoProfileState
Android.Telecom.VideoProfileState.Bidirectional = 3 -> Android.Telecom.VideoProfileState
Android.Telecom.VideoProfileState.Bidirectional = Android.Telecom.VideoProfileState.TxEnabled | Android.Telecom.VideoProfileState.RxEnabled -> Android.Telecom.VideoProfileState
Android.Telecom.VideoProfileState.Paused = 4 -> Android.Telecom.VideoProfileState
Android.Telecom.VideoProfileState.RxEnabled = 2 -> Android.Telecom.VideoProfileState
Android.Telecom.VideoProfileState.TxEnabled = 1 -> Android.Telecom.VideoProfileState
Expand Down Expand Up @@ -34020,7 +34020,7 @@ Android.Text.Util.Linkify.Linkify() -> void
Android.Text.Util.Linkify.Linkify(nint javaReference, Android.Runtime.JniHandleOwnership transfer) -> void
Android.Text.Util.LinkifyIMatchFilterExtensions
Android.Text.Util.MatchOptions
Android.Text.Util.MatchOptions.All = 15 -> Android.Text.Util.MatchOptions
Android.Text.Util.MatchOptions.All = Android.Text.Util.MatchOptions.WebUrls | Android.Text.Util.MatchOptions.EmailAddresses | Android.Text.Util.MatchOptions.PhoneNumbers | Android.Text.Util.MatchOptions.MapAddresses -> Android.Text.Util.MatchOptions
Android.Text.Util.MatchOptions.EmailAddresses = 2 -> Android.Text.Util.MatchOptions
Android.Text.Util.MatchOptions.MapAddresses = 8 -> Android.Text.Util.MatchOptions
Android.Text.Util.MatchOptions.PhoneNumbers = 4 -> Android.Text.Util.MatchOptions
Expand Down Expand Up @@ -37862,15 +37862,15 @@ Android.Views.ShowAsAction.IfRoom = 1 -> Android.Views.ShowAsAction
Android.Views.ShowAsAction.Never = 0 -> Android.Views.ShowAsAction
Android.Views.ShowAsAction.WithText = 4 -> Android.Views.ShowAsAction
Android.Views.SoftInput
Android.Views.SoftInput.AdjustNothing = 48 -> Android.Views.SoftInput
Android.Views.SoftInput.AdjustNothing = Android.Views.SoftInput.AdjustResize | Android.Views.SoftInput.AdjustPan -> Android.Views.SoftInput
Android.Views.SoftInput.AdjustPan = 32 -> Android.Views.SoftInput
Android.Views.SoftInput.AdjustResize = 16 -> Android.Views.SoftInput
Android.Views.SoftInput.AdjustUnspecified = 0 -> Android.Views.SoftInput
Android.Views.SoftInput.IsForwardNavigation = 256 -> Android.Views.SoftInput
Android.Views.SoftInput.MaskAdjust = 240 -> Android.Views.SoftInput
Android.Views.SoftInput.MaskState = 15 -> Android.Views.SoftInput
Android.Views.SoftInput.StateAlwaysHidden = 3 -> Android.Views.SoftInput
Android.Views.SoftInput.StateAlwaysVisible = 5 -> Android.Views.SoftInput
Android.Views.SoftInput.StateAlwaysHidden = Android.Views.SoftInput.StateUnchanged | Android.Views.SoftInput.StateHidden -> Android.Views.SoftInput
Android.Views.SoftInput.StateAlwaysVisible = Android.Views.SoftInput.StateUnchanged | Android.Views.SoftInput.StateVisible -> Android.Views.SoftInput
Android.Views.SoftInput.StateHidden = 2 -> Android.Views.SoftInput
Android.Views.SoftInput.StateUnchanged = 1 -> Android.Views.SoftInput
Android.Views.SoftInput.StateUnspecified = 0 -> Android.Views.SoftInput
Expand Down
Loading