Generator support for api.xml style java docs for parameter names #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix to detect api.xml style java docs when using ClassParse
This will allow api.xml style documents to be specified as java doc inputs for the ClassParse task. Java.Interop already knows how to handle this doc source type.
|
@Redth, |
Contributor
|
@Redth can you rebase this branch please. That will fix most of those test failures |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Nov 30, 2021
Fixes: dotnet/java-interop#815 Fixes: dotnet/java-interop#920 Changes: dotnet/java-interop@0293360...7f1a5ab * dotnet/java-interop@7f1a5ab1: [JavaTypeSystem] Enable resolving generic types on declaring types (dotnet#916) * dotnet/java-interop@8daa0263: [Xamarin.Android.Tools.Bytecode] Fix Nullability warnings (dotnet#922) * dotnet/java-interop@77c9c5fa: [class-parse] Import parameter names for unresolvable types (dotnet#921) * dotnet/java-interop@a8b444d5: [Java.Interop.Tools.JavaTypeSystem] ctors w/ generic type parameters (dotnet#919)
jonpryor
added a commit
that referenced
this pull request
Nov 30, 2021
Fixes: dotnet/java-interop#815 Fixes: dotnet/java-interop#920 Changes: dotnet/java-interop@0293360...7f1a5ab * dotnet/java-interop@7f1a5ab1: [JavaTypeSystem] Enable resolving generic types on declaring types (#916) * dotnet/java-interop@8daa0263: [Xamarin.Android.Tools.Bytecode] Fix Nullability warnings (#922) * dotnet/java-interop@77c9c5fa: [class-parse] Import parameter names for unresolvable types (#921) * dotnet/java-interop@a8b444d5: [Java.Interop.Tools.JavaTypeSystem] ctors w/ generic type parameters (#919)
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 30, 2021
Fixes: dotnet/java-interop#815 Fixes: dotnet/java-interop#920 Changes: dotnet/java-interop@0293360...7f1a5ab * dotnet/java-interop@7f1a5ab1: [JavaTypeSystem] Enable resolving generic types on declaring types (#916) * dotnet/java-interop@8daa0263: [Xamarin.Android.Tools.Bytecode] Fix Nullability warnings (#922) * dotnet/java-interop@77c9c5fa: [class-parse] Import parameter names for unresolvable types (#921) * dotnet/java-interop@a8b444d5: [Java.Interop.Tools.JavaTypeSystem] ctors w/ generic type parameters (#919)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to binding projects to make use of
ApiXmlDocPathsas a project property for includingapi.xmlstyle java docs to be used byClassParsefor resolving parameter names.This format is used by Android Support libraries (and eventually Google Play Services / Firebase).
This requires dotnet/java-interop@4d6c5a9