Fix Analyser to work with global types#9680
Merged
jonathanpeppers merged 4 commits intomainfrom Jan 14, 2025
Merged
Conversation
jonathanpeppers
approved these changes
Jan 14, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
This looks good now, I reran some test lanes.
grendello
added a commit
that referenced
this pull request
Jan 15, 2025
* main: [illink] consolidate & remove hardcoded assembly names (#9662) Bump to NuGet/NuGet.Client@aa7eb998 (#9682) [Microsoft.Android.Sdk.Analysis] fix global types (#9680)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing the following error in maui apps.
this is because they are using
global::Android.Runtime.JniHandleOwnershiprather thanAndroid.Runtime.JniHandleOwnership. This causes our string comparisons to fail to we report a false error message.Rather than using
.ToString()we should switch over to usingQualifiedNameSyntaxandIdentifierNameSyntaxto get the name of the class. This allows us to remove some string comparisons as we can now get the name of the class without the full namespace if it has aglobal::prefix.