Skip to content

[Mono.Android-Tests] Ignore "BadGateway" test failures. #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Jan 16, 2025
Merged

[Mono.Android-Tests] Ignore "BadGateway" test failures. #9687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidClientHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,8 @@ public void Redirect_Without_Protocol_Works()
RunIgnoringNetworkIssues (() => tr.Wait (), out connectionFailed);
if (connectionFailed)
return;

tr.Result.EnsureSuccessStatusCode ();
EnsureSuccessStatusCode (tr.Result);
Assert.AreEqual (redirectedURI, tr.Result.RequestMessage.RequestUri, "Invalid redirected URI");
}
}
Expand All @@ -281,10 +281,21 @@ public void Redirect_POST_With_Content_Works ()
if (connectionFailed)
return;

response.EnsureSuccessStatusCode ();
EnsureSuccessStatusCode (response);
Assert.AreEqual (redirectedURI, response.RequestMessage.RequestUri, "Invalid redirected URI");
}
}

void EnsureSuccessStatusCode (HttpResponseMessage response)
{
// If we hit a 502 (which is quite common on CI) just ignore the test
if (response.StatusCode == HttpStatusCode.BadGateway) {
Assert.Ignore ($"Ignoring network failure: {response.StatusCode}");
return;
}

response.EnsureSuccessStatusCode ();
}
}

[TestFixture]
Expand Down
Loading