Store SHA/version of synced repos in VMR using .props files#2014
Merged
Conversation
tkapin
previously approved these changes
Sep 9, 2022
tkapin
previously approved these changes
Sep 12, 2022
tkapin
approved these changes
Sep 12, 2022
premun
changed the title
.props files.props files
premun
added a commit
to dotnet/installer
that referenced
this pull request
Sep 14, 2022
Previously, the recursive clone of all the product repos based on `Version.Details.xml` files was done inside MSBuild but the VMR tooling can now do that (dotnet/arcade-services#2004). This replaces the need for the Source-Build tasks (Read/Write, recursive clone). Secondly, `git-info` props files are now created by the CLI too (dotnet/arcade-services#2014).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag files are no longer used and commit SHA / version for each synchronized individual repository is stored in/read from:
git-info/AllRepoVersions.propsfilegit-info/[repo].propsVmrManagernow also reads the package versions fromVersion.Details.xmland stores it too.These files are the same as Source-Build tarball uses (link). The logic is the same, only uses
Version.Details.xmlreader fromDarcLib. The tarball tasks could utilize this and code could be removed fromdotnet/installerif we want.Resolves dotnet/arcade#10264