Fix ef migrations#6232
Merged
dkurepa merged 2 commits intodotnet:mainfrom Apr 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a breaking change introduced by upgrading Microsoft.Data.SqlClient to 7.0.1 (in #6225) by ensuring the Azure/Entra authentication extensions are available and updating managed identity credential construction to the newer Azure.Identity API.
Changes:
- Add
Microsoft.Data.SqlClient.Extensions.Azureso SqlClient’s Entra authentication flows work (notably for EF migrations). - Update managed identity credential creation to use
ManagedIdentityIdAPIs (SystemAssigned/FromUserAssignedClientId). - Bump supporting dependency versions (
Azure.Identityand a fewMicrosoft.Extensions.*patch versions) to satisfy the new auth stack.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Maestro/Maestro.Data/Maestro.Data.csproj |
Adds SqlClient Azure extensions package needed for Entra/MI authentication scenarios (including EF migrations). |
src/Maestro/Maestro.Common/AzureDevOpsTokens/AzureDevOpsTokenProvider.cs |
Switches managed identity credential creation to ManagedIdentityId-based constructors. |
src/Maestro/Maestro.Common/AppCredentials/CredentialResolver.cs |
Updates managed identity credential creation to the new Azure.Identity API surface. |
src/Maestro/Maestro.Common/AppCredentials/AppCredential.cs |
Updates MI credential creation used for client assertion flows to the new Azure.Identity API surface. |
Directory.Packages.props |
Central package updates: bumps Azure.Identity, adds Microsoft.Data.SqlClient.Extensions.Azure, and updates a few Microsoft.Extensions.* patch versions. |
adamzip
approved these changes
Apr 28, 2026
premun
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6239
In #6225 we updated Microsoft.Data.SqlClient from 6.1.4 to 7.0.1, which had a breaking change. This should fix it
Testing in https://dev.azure.com/dnceng/internal/_build/results?buildId=2961486&view=results