Skip to content

Fix ef migrations#6232

Merged
dkurepa merged 2 commits intodotnet:mainfrom
dkurepa:dkurepa/EfMigrationFix
Apr 28, 2026
Merged

Fix ef migrations#6232
dkurepa merged 2 commits intodotnet:mainfrom
dkurepa:dkurepa/EfMigrationFix

Conversation

@dkurepa
Copy link
Copy Markdown
Member

@dkurepa dkurepa commented Apr 27, 2026

#6239
In #6225 we updated Microsoft.Data.SqlClient from 6.1.4 to 7.0.1, which had a breaking change. This should fix it

Testing in https://dev.azure.com/dnceng/internal/_build/results?buildId=2961486&view=results

Copilot AI review requested due to automatic review settings April 27, 2026 17:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a breaking change introduced by upgrading Microsoft.Data.SqlClient to 7.0.1 (in #6225) by ensuring the Azure/Entra authentication extensions are available and updating managed identity credential construction to the newer Azure.Identity API.

Changes:

  • Add Microsoft.Data.SqlClient.Extensions.Azure so SqlClient’s Entra authentication flows work (notably for EF migrations).
  • Update managed identity credential creation to use ManagedIdentityId APIs (SystemAssigned / FromUserAssignedClientId).
  • Bump supporting dependency versions (Azure.Identity and a few Microsoft.Extensions.* patch versions) to satisfy the new auth stack.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Maestro/Maestro.Data/Maestro.Data.csproj Adds SqlClient Azure extensions package needed for Entra/MI authentication scenarios (including EF migrations).
src/Maestro/Maestro.Common/AzureDevOpsTokens/AzureDevOpsTokenProvider.cs Switches managed identity credential creation to ManagedIdentityId-based constructors.
src/Maestro/Maestro.Common/AppCredentials/CredentialResolver.cs Updates managed identity credential creation to the new Azure.Identity API surface.
src/Maestro/Maestro.Common/AppCredentials/AppCredential.cs Updates MI credential creation used for client assertion flows to the new Azure.Identity API surface.
Directory.Packages.props Central package updates: bumps Azure.Identity, adds Microsoft.Data.SqlClient.Extensions.Azure, and updates a few Microsoft.Extensions.* patch versions.

@dkurepa dkurepa merged commit 107f880 into dotnet:main Apr 28, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants